You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@drill.apache.org by "Jacques Nadeau (JIRA)" <ji...@apache.org> on 2014/12/05 07:36:14 UTC

[jira] [Commented] (DRILL-1812) SingleSender blocking rpc thread

    [ https://issues.apache.org/jira/browse/DRILL-1812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14235165#comment-14235165 ] 

Jacques Nadeau commented on DRILL-1812:
---------------------------------------

Nice catch.  Looks good to me. +1

> SingleSender blocking rpc thread
> --------------------------------
>
>                 Key: DRILL-1812
>                 URL: https://issues.apache.org/jira/browse/DRILL-1812
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: Steven Phillips
>         Attachments: DRILL-1812.patch
>
>
> When the send fails in SingleSender, the listener calls stop(), which creates two problems. First, stop() calls the cleanup()  method, which can cause buffers to be removed while the execution thread is still using them. Second, this method blocks on waitForSendComlete(), and we never want to block the rpc thread, as this can lead to the drillbit becoming unresponsive.
> The stop() method should not be called by thread other than the execution thread.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)