You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/01/24 07:43:53 UTC

[GitHub] [spark] HeartSaVioR opened a new pull request #35298: [SPARK-37987][SS] Fix flaky test StreamingAggregationSuite.changing schema of state when restarting query

HeartSaVioR opened a new pull request #35298:
URL: https://github.com/apache/spark/pull/35298


   ### What changes were proposed in this pull request?
   
   This PR fixes a flaky test `StreamingAggregationSuite.changing schema of state when restarting query`, via adjusting the number of shuffle partition to 1.
   
   The flakiness was due to the optimization on schema verification - we only verify it in partition 0 since it is costly and redundant to verify the schema for all partitions. Other partitions are still possible to provide other errors which are considered as unexpected.
   
   ### Why are the changes needed?
   
   This PR fixes a flaky test.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Ran test suite 10 times locally.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HeartSaVioR commented on pull request #35298: [SPARK-37987][SS] Fix flaky test StreamingAggregationSuite.changing schema of state when restarting query

Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on pull request #35298:
URL: https://github.com/apache/spark/pull/35298#issuecomment-1019804483


   cc. @HyukjinKwon 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #35298: [SPARK-37987][SS] Fix flaky test StreamingAggregationSuite.changing schema of state when restarting query

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35298:
URL: https://github.com/apache/spark/pull/35298#issuecomment-1019812561


   Thanks man!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HeartSaVioR commented on pull request #35298: [SPARK-37987][SS] Fix flaky test StreamingAggregationSuite.changing schema of state when restarting query

Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on pull request #35298:
URL: https://github.com/apache/spark/pull/35298#issuecomment-1019841867


   Thanks! Merging to master/3.2.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HeartSaVioR closed pull request #35298: [SPARK-37987][SS] Fix flaky test StreamingAggregationSuite.changing schema of state when restarting query

Posted by GitBox <gi...@apache.org>.
HeartSaVioR closed pull request #35298:
URL: https://github.com/apache/spark/pull/35298


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org