You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "abhishekrb19 (via GitHub)" <gi...@apache.org> on 2023/06/01 17:35:45 UTC
[GitHub] [druid] abhishekrb19 commented on a diff in pull request #14355: Handle StreamExceptions when initializing input source
abhishekrb19 commented on code in PR #14355:
URL: https://github.com/apache/druid/pull/14355#discussion_r1213476581
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/RecordSupplierInputSource.java:
##########
@@ -68,29 +69,35 @@ public RecordSupplierInputSource(
this.recordSupplier = recordSupplier;
this.useEarliestOffset = useEarliestOffset;
this.iteratorTimeoutMs = iteratorTimeoutMs;
- try {
- assignAndSeek(recordSupplier);
- }
- catch (InterruptedException e) {
- throw new SamplerException(e, "Exception while seeking to partitions");
- }
+
+ assignAndSeek(recordSupplier);
}
private void assignAndSeek(RecordSupplier<PartitionIdType, SequenceOffsetType, RecordType> recordSupplier)
- throws InterruptedException
{
- final Set<StreamPartition<PartitionIdType>> partitions = recordSupplier
- .getPartitionIds(topic)
- .stream()
- .map(partitionId -> StreamPartition.of(topic, partitionId))
- .collect(Collectors.toSet());
-
- recordSupplier.assign(partitions);
-
- if (useEarliestOffset) {
- recordSupplier.seekToEarliest(partitions);
- } else {
- recordSupplier.seekToLatest(partitions);
+ try {
+ final Set<StreamPartition<PartitionIdType>> partitions = recordSupplier
+ .getPartitionIds(topic)
+ .stream()
+ .map(partitionId -> StreamPartition.of(topic, partitionId))
+ .collect(Collectors.toSet());
+
+ recordSupplier.assign(partitions);
+
+ if (useEarliestOffset) {
+ recordSupplier.seekToEarliest(partitions);
+ } else {
+ recordSupplier.seekToLatest(partitions);
+ }
+ }
+ catch (Exception e) {
+ throw new SamplerException(
+ e,
+ "Exception while seeking to the [%s] offset of partitions in topic [%s]: %s",
+ useEarliestOffset ? "earliest" : "latest",
Review Comment:
Neat!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org