You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/20 06:35:35 UTC

[GitHub] [flink] maosuhan commented on pull request #14376: [FLINK-18202][PB format] New Format of protobuf

maosuhan commented on PR #14376:
URL: https://github.com/apache/flink/pull/14376#issuecomment-1160032898

   > Thanks for starting the review @libenchao - I have one comment about this one
   > 
   > > 2. I noticed you introduced scala dependency for this module, hence we'd better to add the scala version to the artifactId
   > 
   > We can't have a Scala dependency in a formats PR. Since Flink 1.15 we have the situation that our Java users don't need to rely on Scala and this PR would break that.
   
   The main reason I use scala in the code is that it's more clear to write codegen code. In the first version of this PR, I used java code to do that. If we cannot use scala dependency in format modules, I will revert the scala code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org