You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu> on 2025/07/10 14:55:41 UTC

Change in asterixdb[ionic]: ignore2: debug

From Ritik Raj <ri...@couchbase.com>:

Ritik Raj has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20063 )


Change subject: ignore2: debug
......................................................................

ignore2: debug

Change-Id: If1120a68ffaeed3c48b0cadb9cc66de6ca6bda96
---
M asterixdb/asterix-column/src/main/java/org/apache/asterix/column/tuple/MergeColumnTupleReference.java
M asterixdb/asterix-column/src/main/java/org/apache/asterix/column/operation/lsm/merge/MergeColumnTupleWriter.java
2 files changed, 20 insertions(+), 10 deletions(-)



  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/63/20063/1

diff --git a/asterixdb/asterix-column/src/main/java/org/apache/asterix/column/operation/lsm/merge/MergeColumnTupleWriter.java b/asterixdb/asterix-column/src/main/java/org/apache/asterix/column/operation/lsm/merge/MergeColumnTupleWriter.java
index fb5cfdb..b43cfb5 100644
--- a/asterixdb/asterix-column/src/main/java/org/apache/asterix/column/operation/lsm/merge/MergeColumnTupleWriter.java
+++ b/asterixdb/asterix-column/src/main/java/org/apache/asterix/column/operation/lsm/merge/MergeColumnTupleWriter.java
@@ -72,11 +72,12 @@
         this.componentsTuples = new MergeColumnTupleReference[componentsTuplesList.size()];
         int totalLength = 0;
         int totalNumberOfTuples = 0;
+        presentColumnsIndexes.set(0, columnMetadata.getNumberOfColumns());
         for (int i = 0; i < componentsTuplesList.size(); i++) {
             MergeColumnTupleReference mergeTuple = (MergeColumnTupleReference) componentsTuplesList.get(i);
             this.componentsTuples[i] = mergeTuple;
             mergeTuple.registerEndOfPageCallBack(this::writeAllColumns);
-            mergeTuple.setColumnIndexes(presentColumnsIndexes);
+            //            mergeTuple.setColumnIndexes(presentColumnsIndexes);
             totalNumberOfTuples += mergeTuple.getTupleCount();
             totalLength += mergeTuple.getMergingLength();
         }
@@ -125,12 +126,12 @@
     @Override
     public void writeTuple(ITupleReference tuple) throws HyracksDataException {
         MergeColumnTupleReference columnTuple = (MergeColumnTupleReference) tuple;
-        if (numberOfTuples == 0) {
-            // fill with the columnIndexes
-            for (MergeColumnTupleReference componentsTuple : componentsTuples) {
-                componentsTuple.fillColumnIndexes();
-            }
-        }
+        //        if (numberOfTuples == 0) {
+        //            // fill with the columnIndexes
+        //            for (MergeColumnTupleReference componentsTuple : componentsTuples) {
+        //                componentsTuple.fillColumnIndexes();
+        //            }
+        //        }
         numberOfTuples++;
         int componentIndex = columnTuple.getComponentIndex();
         int skipCount = columnTuple.getAndResetSkipCount();
diff --git a/asterixdb/asterix-column/src/main/java/org/apache/asterix/column/tuple/MergeColumnTupleReference.java b/asterixdb/asterix-column/src/main/java/org/apache/asterix/column/tuple/MergeColumnTupleReference.java
index eb12a27..45ac324 100644
--- a/asterixdb/asterix-column/src/main/java/org/apache/asterix/column/tuple/MergeColumnTupleReference.java
+++ b/asterixdb/asterix-column/src/main/java/org/apache/asterix/column/tuple/MergeColumnTupleReference.java
@@ -93,9 +93,9 @@
     public void newPage() throws HyracksDataException {
         super.newPage();
         // the tuples are being read, meanwhile MegaLeaf changed
-        if (presentColumnIndexes != null) {
-            frame.getAllColumns(presentColumnIndexes);
-        }
+        //        if (presentColumnIndexes != null) {
+        //            frame.getAllColumns(presentColumnIndexes);
+        //        }
     }
 
     @Override

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20063
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: ionic
Gerrit-Change-Id: If1120a68ffaeed3c48b0cadb9cc66de6ca6bda96
Gerrit-Change-Number: 20063
Gerrit-PatchSet: 1
Gerrit-Owner: Ritik Raj <ri...@couchbase.com>
Gerrit-MessageType: newchange