You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samoa.apache.org by mgrzenda <gi...@git.apache.org> on 2017/07/19 13:36:42 UTC
[GitHub] incubator-samoa pull request #68: SAMOA-71: fixes concurrency issues in Hori...
GitHub user mgrzenda opened a pull request:
https://github.com/apache/incubator-samoa/pull/68
SAMOA-71: fixes concurrency issues in HorizontalAMRulesRegressor
I suggest a change in ruleSet implementation from LinkedList (providing fail-fast iterators, which causes ConcurrencyException when list content changes during iterating over it) to CopyOnWriteArrayList (which is a thread-safe variant eliminating concurrency exceptions). In the analysed case, the modifications to ruleSet are expected to be much less frequent than reading the rules. When the number of read operations is relatively large and update operations are far less frequent, a possible choice is CopyOnWriteArrayList.
I have compared the performance on 35k instance streams (with a higher than 35k number concurrency exception got thrown) and got the same <1 second processing time. Hence, the possible negative impact on the performance can be considered negligible, if any. Still, suggestions and possible other solution ideas from designers of AMRules are welcome.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mgrzenda/incubator-samoa SAMOA-71
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-samoa/pull/68.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #68
----
commit b2ebe028bf2fc24b9f41605d5075f6706c6e6e3d
Author: Maciej Grzenda <ma...@gmail.com>
Date: 2017-07-19T13:12:35Z
SAMOA-71: fixes concurrency issues in HorizontalAMRulesRegressor
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-samoa issue #68: SAMOA-71: fixes concurrency issues in HorizontalA...
Posted by mgrzenda <gi...@git.apache.org>.
Github user mgrzenda commented on the issue:
https://github.com/apache/incubator-samoa/pull/68
Recent automated builds ten to be slow and exceed timeouts. This commit increases the values limiting the time allocated to Storm tests. This is to prevent the failure of these tests and entire Travis build in turn.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-samoa issue #68: SAMOA-71: fixes concurrency issues in HorizontalA...
Posted by gdfm <gi...@git.apache.org>.
Github user gdfm commented on the issue:
https://github.com/apache/incubator-samoa/pull/68
+1, looks good to me.
Thanks for the fix!
---
[GitHub] incubator-samoa issue #68: SAMOA-71: fixes concurrency issues in HorizontalA...
Posted by abifet <gi...@git.apache.org>.
Github user abifet commented on the issue:
https://github.com/apache/incubator-samoa/pull/68
+1
Thanks! That's a nice improvement.
---
[GitHub] incubator-samoa pull request #68: SAMOA-71: fixes concurrency issues in Hori...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-samoa/pull/68
---
[GitHub] incubator-samoa issue #68: SAMOA-71: fixes concurrency issues in HorizontalA...
Posted by djKooks <gi...@git.apache.org>.
Github user djKooks commented on the issue:
https://github.com/apache/incubator-samoa/pull/68
Now test goes well. Thanks!
---