You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2020/02/05 21:59:49 UTC
Review Request 72087: Cleaned up agent capability validation and
associated docs.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72087/
-----------------------------------------------------------
Review request for mesos, Andrei Budnik and Qian Zhang.
Repository: mesos
Description
-------
Cleaned up agent capability validation and associated docs.
Diffs
-----
docs/configuration/agent.md 0e703d8173aa1e5cac205f9626ab014853a3acce
src/slave/flags.cpp 0f159a354d8d90ffb37d0032a3d1b69998bbe53c
Diff: https://reviews.apache.org/r/72087/diff/1/
Testing
-------
`make check`
Thanks,
Greg Mann
Re: Review Request 72087: Cleaned up agent capability validation and
associated docs.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72087/#review219515
-----------------------------------------------------------
Ship it!
Ship It!
- Qian Zhang
On Feb. 6, 2020, 5:59 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72087/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2020, 5:59 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Qian Zhang.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Cleaned up agent capability validation and associated docs.
>
>
> Diffs
> -----
>
> docs/configuration/agent.md 0e703d8173aa1e5cac205f9626ab014853a3acce
> src/slave/flags.cpp 0f159a354d8d90ffb37d0032a3d1b69998bbe53c
>
>
> Diff: https://reviews.apache.org/r/72087/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72087: Cleaned up agent capability validation and
associated docs.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72087/#review219514
-----------------------------------------------------------
Patch looks great!
Reviews applied: [71991, 72087]
Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh
- Mesos Reviewbot
On Feb. 5, 2020, 9:59 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72087/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2020, 9:59 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Qian Zhang.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Cleaned up agent capability validation and associated docs.
>
>
> Diffs
> -----
>
> docs/configuration/agent.md 0e703d8173aa1e5cac205f9626ab014853a3acce
> src/slave/flags.cpp 0f159a354d8d90ffb37d0032a3d1b69998bbe53c
>
>
> Diff: https://reviews.apache.org/r/72087/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>