You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "gustavonihei (via GitHub)" <gi...@apache.org> on 2023/04/03 19:00:22 UTC
[GitHub] [nuttx] gustavonihei opened a new pull request, #8954: risc-v/espressif: Panic if CPU interrupt allocation fails
gustavonihei opened a new pull request, #8954:
URL: https://github.com/apache/nuttx/pull/8954
## Summary
This PR intends to simplify the error handling of CPU interrupt allocation for Espressif's chis supported within `risc-v/espressif` tree.
Instead of propagating an `-ENOMEM` error value, `esp_setup_irq` now adopts a fail-fast approach and simply panics. CPU interrupt allocation errors are unrecoverable, so the reliability of the execution becomes compromised.
## Impact
Serial driver no longer performs the error checking, resulting is less code.
## Testing
Verification in internal CI that all available defconfig within `boards/risc-v/espressif` boot properly.
Also forced the error by hardcoding `esp_cpuint_alloc` return value as `-ENOMEM`:
```
esp_setup_irq: Unable to allocate CPU interrupt for source=1
_assert: Current Version: NuttX 10.4.0 12fda1da1c-dirty Apr 3 2023 15:29:42 risc-v
_assert: Assertion failed panic: at file: chip/esp_irq.c:454 task: Idle Task 0x42003f5a
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] acassis merged pull request #8954: risc-v/espressif: Panic if CPU interrupt allocation fails
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis merged PR #8954:
URL: https://github.com/apache/nuttx/pull/8954
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org