[jira] Commented: (DIRMINA-673) Build produces invalid jar file

["Chris Custine (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DIRMINA-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682213#action_12682213 ] 

Chris Custine commented on DIRMINA-673:
---------------------------------------

The main cause of this is the use of the ant zip task to explode and recreate the jar file.

This patch removes the rather clunky ant task to move the ASL 2.0, jzlib, ognl, slf4j, and springframework into each jar file after it is built.  I don't think these 3rd party license files are necessary in *each* jar file and should only be necessary in the larger assembly archives because that is the only download that includes them.  This patch makes use of the remote-resources plugin that inserts all of the required ASL LICENSE and NOTICE files in the jars and just includes the 3rd party licenses in the assembly archive.

This patch also creates mina-legal and mina-parent modules in order to  work around some cyclic dependencies but this is very normal in many maven projects these days.  This is a large patch so let me know if there is anything I can change to suit you.

> Build produces invalid jar file
> -------------------------------
>
>                 Key: DIRMINA-673
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-673
>             Project: MINA
>          Issue Type: Bug
>    Affects Versions: 2.0.0-M4
>            Reporter: Chris Custine
>         Attachments: DIRMINA-673.patch
>
>
> The build step for adding license files via the ant zip task produces invalid jar files because the manifest is not guaranteed to be the first file in the archive (part of the jar spec).  This is affecting deployment in OSGi containers and any other code that uses JarInputStream to read the manifest prior to deployment because it expects the manifest to be the first file in the archive.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.