You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/09/22 02:15:10 UTC

[GitHub] [orc] guiyanakuang commented on a change in pull request #915: ORC-98: Add support for t-digests to ORC

guiyanakuang commented on a change in pull request #915:
URL: https://github.com/apache/orc/pull/915#discussion_r713539981



##########
File path: java/core/pom.xml
##########
@@ -75,6 +75,10 @@
       <groupId>org.threeten</groupId>
       <artifactId>threeten-extra</artifactId>
     </dependency>
+    <dependency>
+      <groupId>com.tdunning</groupId>

Review comment:
       > This reminds me the following Spark PR. In the community, it's a little hard to add this kind of dependency without a significant justification.
   > 
   > * https://github.com/apache/spark/pull/26197/files#diff-283ead138b37209525130359830c4c6eeafaf5c6639b0df82b770389d24002bfR134
   
   I understand the point and the fear of not being maintained. But the actual algorithm is short and easy to understand.
   
   > https://github.com/addthis/stream-lib/blob/master/src/main/java/com/clearspring/analytics/stream/quantile/TDigest.java
   
   Can I copy this file into the ORC project instead of the dependency? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org