You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "qixiaobo (GitHub)" <gi...@apache.org> on 2019/08/19 11:23:19 UTC
[GitHub] [dubbo] qixiaobo opened pull request #4880: dubbo zookeeper
registry too slow
ref to #4828
I just add concurrentHashSet to avoid checking persistent node exist
[ Full content available at: https://github.com/apache/dubbo/pull/4880 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo] codecov-io commented on issue #4880: dubbo zookeeper
registry too slow
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/4880?src=pr&el=h1) Report
> Merging [#4880](https://codecov.io/gh/apache/dubbo/pull/4880?src=pr&el=desc) into [master](https://codecov.io/gh/apache/dubbo/commit/00653c39b0f90206c1e3357268b991fff6c78535?src=pr&el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `57.14%`.
[](https://codecov.io/gh/apache/dubbo/pull/4880?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4880 +/- ##
============================================
- Coverage 63.97% 63.93% -0.04%
- Complexity 452 453 +1
============================================
Files 769 769
Lines 33157 33168 +11
Branches 5228 5232 +4
============================================
- Hits 21211 21206 -5
- Misses 9525 9545 +20
+ Partials 2421 2417 -4
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/4880?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ing/zookeeper/support/AbstractZookeeperClient.java](https://codecov.io/gh/apache/dubbo/pull/4880/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3Rpbmctem9va2VlcGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy96b29rZWVwZXIvc3VwcG9ydC9BYnN0cmFjdFpvb2tlZXBlckNsaWVudC5qYXZh) | `67.04% <57.14%> (-3.33%)` | `0 <0> (ø)` | |
| [.../apache/dubbo/qos/protocol/QosProtocolWrapper.java](https://codecov.io/gh/apache/dubbo/pull/4880/diff?src=pr&el=tree#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3Byb3RvY29sL1Fvc1Byb3RvY29sV3JhcHBlci5qYXZh) | `65.85% <0%> (-17.08%)` | `0% <0%> (ø)` | |
| [...ache/dubbo/remoting/transport/AbstractChannel.java](https://codecov.io/gh/apache/dubbo/pull/4880/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RDaGFubmVsLmphdmE=) | `75% <0%> (-12.5%)` | `0% <0%> (ø)` | |
| [...o/rpc/cluster/loadbalance/AbstractLoadBalance.java](https://codecov.io/gh/apache/dubbo/pull/4880/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvbG9hZGJhbGFuY2UvQWJzdHJhY3RMb2FkQmFsYW5jZS5qYXZh) | `42.85% <0%> (-10.09%)` | `0% <0%> (ø)` | |
| [...bbo/registry/support/ProviderConsumerRegTable.java](https://codecov.io/gh/apache/dubbo/pull/4880/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9zdXBwb3J0L1Byb3ZpZGVyQ29uc3VtZXJSZWdUYWJsZS5qYXZh) | `80.48% <0%> (-4.88%)` | `0% <0%> (ø)` | |
| [.../dubbo/monitor/support/AbstractMonitorFactory.java](https://codecov.io/gh/apache/dubbo/pull/4880/diff?src=pr&el=tree#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbW9uaXRvci9zdXBwb3J0L0Fic3RyYWN0TW9uaXRvckZhY3RvcnkuamF2YQ==) | `78.37% <0%> (-2.71%)` | `0% <0%> (ø)` | |
| [.../rpc/protocol/dubbo/LazyConnectExchangeClient.java](https://codecov.io/gh/apache/dubbo/pull/4880/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0xhenlDb25uZWN0RXhjaGFuZ2VDbGllbnQuamF2YQ==) | `56.47% <0%> (-2.36%)` | `0% <0%> (ø)` | |
| [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/dubbo/pull/4880/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `60.86% <0%> (-2.18%)` | `0% <0%> (ø)` | |
| [...g/apache/dubbo/registry/consul/ConsulRegistry.java](https://codecov.io/gh/apache/dubbo/pull/4880/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktY29uc3VsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jb25zdWwvQ29uc3VsUmVnaXN0cnkuamF2YQ==) | `61.87% <0%> (-0.63%)` | `29% <0%> (ø)` | |
| [...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java](https://codecov.io/gh/apache/dubbo/pull/4880/diff?src=pr&el=tree#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWRlZmF1bHQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL21vbml0b3IvZHViYm8vRHViYm9Nb25pdG9yLmphdmE=) | `90.65% <0%> (+0.93%)` | `17% <0%> (+1%)` | :arrow_up: |
| ... and [4 more](https://codecov.io/gh/apache/dubbo/pull/4880/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/4880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/4880?src=pr&el=footer). Last update [00653c3...8c92462](https://codecov.io/gh/apache/dubbo/pull/4880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo/pull/4880 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org