You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ru...@apache.org on 2026/06/01 17:30:13 UTC
(superset) branch master updated: fix(embedded): resolve guest user permissions in user_view_menu_names (#39197)
This is an automated email from the ASF dual-hosted git repository.
rusackas pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new 041ecbc248c fix(embedded): resolve guest user permissions in user_view_menu_names (#39197)
041ecbc248c is described below
commit 041ecbc248c030b2389fdb1e0fc2d483558ef9bf
Author: Michael Gerber <mi...@nxt.engineering>
AuthorDate: Mon Jun 1 19:30:05 2026 +0200
fix(embedded): resolve guest user permissions in user_view_menu_names (#39197)
Co-authored-by: Evan Rusackas <ev...@preset.io>
Co-authored-by: Copilot Autofix powered by AI <17...@users.noreply.github.com>
Co-authored-by: Claude Code <no...@anthropic.com>
---
superset/security/manager.py | 17 ++++++++
tests/unit_tests/security/manager_test.py | 72 +++++++++++++++++++++++++++++++
2 files changed, 89 insertions(+)
diff --git a/superset/security/manager.py b/superset/security/manager.py
index db05c200866..a62daa528d3 100644
--- a/superset/security/manager.py
+++ b/superset/security/manager.py
@@ -1143,6 +1143,23 @@ class SupersetSecurityManager( # pylint: disable=too-many-public-methods
.join(self.role_model)
)
+ # Guest users (embedded dashboards) have is_anonymous=False but no
+ # database identity, so querying by user_id returns nothing. Instead,
+ # resolve permissions directly from the roles attached to the guest
+ # token (typically the Public role).
+ if self.is_guest_user():
+ role_ids = [
+ role.id for role in g.user.roles if role and role.id is not None
+ ]
+ if not role_ids:
+ return set()
+ view_menu_names = (
+ base_query.filter(self.role_model.id.in_(role_ids)).filter(
+ self.permission_model.name == permission_name
+ )
+ ).all()
+ return {s.name for s in view_menu_names}
+
if not g.user.is_anonymous:
user_id = get_user_id()
diff --git a/tests/unit_tests/security/manager_test.py b/tests/unit_tests/security/manager_test.py
index ca4b0b8df8b..f5e4190fa6b 100644
--- a/tests/unit_tests/security/manager_test.py
+++ b/tests/unit_tests/security/manager_test.py
@@ -1547,3 +1547,75 @@ def test_validate_child_in_parent_multilayer_null_params(
assert not sm._validate_child_in_parent_multilayer(
child_slice_id=1, parent_slice=parent_slice
)
+
+
+def test_user_view_menu_names_for_guest_user(
+ mocker: MockerFixture,
+ app_context: None,
+) -> None:
+ """
+ Test that user_view_menu_names resolves permissions from the guest
+ user's roles instead of querying by user_id (which is None for guests).
+ """
+ sm = SupersetSecurityManager(appbuilder)
+
+ mock_role = mocker.MagicMock(spec=Role)
+ mock_role.id = 99
+
+ mock_guest = mocker.MagicMock()
+ mock_guest.is_anonymous = False
+ mock_guest.roles = [mock_role]
+
+ mock_g = SimpleNamespace(user=mock_guest)
+ mocker.patch("superset.security.manager.g", new=mock_g)
+ mocker.patch.object(sm, "is_guest_user", return_value=True)
+ # The regression: guest path must NEVER fall through to get_user_id().
+ # Patching it as an error means an accidental fall-through fails loudly.
+ mock_get_user_id = mocker.patch(
+ "superset.security.manager.get_user_id",
+ side_effect=AssertionError("get_user_id must not be called for guest users"),
+ )
+
+ mock_result = [SimpleNamespace(name="[PostgreSQL].[my_table](id:1)")]
+ mock_query = mocker.MagicMock()
+ mock_query.join.return_value = mock_query
+ mock_query.filter.return_value = mock_query
+ mock_query.all.return_value = mock_result
+ mocker.patch.object(sm.session, "query", return_value=mock_query)
+
+ result = sm.user_view_menu_names("datasource_access")
+
+ assert result == {"[PostgreSQL].[my_table](id:1)"}
+ mock_get_user_id.assert_not_called()
+ mock_query.filter.assert_called()
+
+
+def test_user_view_menu_names_for_guest_user_no_roles(
+ mocker: MockerFixture,
+ app_context: None,
+) -> None:
+ """
+ Test that user_view_menu_names returns empty set when guest user has
+ no roles with valid IDs.
+ """
+ sm = SupersetSecurityManager(appbuilder)
+
+ mock_role = mocker.MagicMock(spec=Role)
+ mock_role.id = None
+
+ mock_guest = mocker.MagicMock()
+ mock_guest.is_anonymous = False
+ mock_guest.roles = [mock_role]
+
+ mock_g = SimpleNamespace(user=mock_guest)
+ mocker.patch("superset.security.manager.g", new=mock_g)
+ mocker.patch.object(sm, "is_guest_user", return_value=True)
+ mock_get_user_id = mocker.patch(
+ "superset.security.manager.get_user_id",
+ side_effect=AssertionError("get_user_id must not be called for guest users"),
+ )
+
+ result = sm.user_view_menu_names("datasource_access")
+
+ assert result == set()
+ mock_get_user_id.assert_not_called()