You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/12/12 23:15:29 UTC
[GitHub] [spark] linzebing opened a new pull request #30749: [MINOR][UI] Correct JobPage's skipped/pending tableHeaderId
linzebing opened a new pull request #30749:
URL: https://github.com/apache/spark/pull/30749
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Current Spark Web UI job page's header link of pending/skipped stages is inconsistent with their status. See the picture below
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
The code determining the `pendingOrSkippedTableId` has the wrong logic. As explained in the code:
> If the job is completed, then any pending stages are displayed as "skipped" [code pointer](https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/ui/jobs/JobPage.scala#L266)
This PR fixes the logic for `pendingOrSkippedTableId` which aligns with the stage statuses.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Verified that header link is consistent with stage status with the fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30749: [MINOR][UI] Correct JobPage's skipped/pending tableHeaderId
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30749:
URL: https://github.com/apache/spark/pull/30749#issuecomment-743922136
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30749: [MINOR][UI] Correct JobPage's skipped/pending tableHeaderId
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30749:
URL: https://github.com/apache/spark/pull/30749#issuecomment-743961442
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37318/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30749: [MINOR][UI] Correct JobPage's skipped/pending tableHeaderId
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30749:
URL: https://github.com/apache/spark/pull/30749#issuecomment-743963804
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37318/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #30749: [MINOR][UI] Correct JobPage's skipped/pending tableHeaderId
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30749:
URL: https://github.com/apache/spark/pull/30749#issuecomment-743936117
cc @sarutak and @gengliangwang FYI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30749: [MINOR][UI] Correct JobPage's skipped/pending tableHeaderId
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30749:
URL: https://github.com/apache/spark/pull/30749#issuecomment-743969429
**[Test build #132715 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132715/testReport)** for PR 30749 at commit [`88d9b3c`](https://github.com/apache/spark/commit/88d9b3c789d1d6c0fd5d51327d925fc98f81b610).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30749: [MINOR][UI] Correct JobPage's skipped/pending tableHeaderId
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30749:
URL: https://github.com/apache/spark/pull/30749#issuecomment-743963804
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37318/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #30749: [MINOR][UI] Correct JobPage's skipped/pending tableHeaderId
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #30749:
URL: https://github.com/apache/spark/pull/30749#issuecomment-743956270
ok to test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30749: [MINOR][UI] Correct JobPage's skipped/pending tableHeaderId
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30749:
URL: https://github.com/apache/spark/pull/30749#issuecomment-743970297
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132715/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30749: [MINOR][UI] Correct JobPage's skipped/pending tableHeaderId
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30749:
URL: https://github.com/apache/spark/pull/30749#issuecomment-743970297
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132715/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #30749: [MINOR][UI] Correct JobPage's skipped/pending tableHeaderId
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #30749:
URL: https://github.com/apache/spark/pull/30749#issuecomment-743995516
Though the screenshot seems to be from `2.4`, I confirmed that `master` also has this issue.
I verified the change with the following script.
```
val stage = sc.parallelize(1 to 10).map(x => (x, x)).reduceByKey(_ + _)
stage.collect
stage.map { x => {Thread.sleep(60000); x} }.reduceByKey(_ + _).collect
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] asfgit closed pull request #30749: [MINOR][UI] Correct JobPage's skipped/pending tableHeaderId
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #30749:
URL: https://github.com/apache/spark/pull/30749
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30749: [MINOR][UI] Correct JobPage's skipped/pending tableHeaderId
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30749:
URL: https://github.com/apache/spark/pull/30749#issuecomment-743957885
**[Test build #132715 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132715/testReport)** for PR 30749 at commit [`88d9b3c`](https://github.com/apache/spark/commit/88d9b3c789d1d6c0fd5d51327d925fc98f81b610).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #30749: [MINOR][UI] Correct JobPage's skipped/pending tableHeaderId
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #30749:
URL: https://github.com/apache/spark/pull/30749#issuecomment-744005887
Merged to `master`, `branch-3.1`, `branch-3.0` and `branch-2.4`. Thanks @linzebing !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30749: [MINOR][UI] Correct JobPage's skipped/pending tableHeaderId
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30749:
URL: https://github.com/apache/spark/pull/30749#issuecomment-743957885
**[Test build #132715 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132715/testReport)** for PR 30749 at commit [`88d9b3c`](https://github.com/apache/spark/commit/88d9b3c789d1d6c0fd5d51327d925fc98f81b610).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30749: [MINOR][UI] Correct JobPage's skipped/pending tableHeaderId
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30749:
URL: https://github.com/apache/spark/pull/30749#issuecomment-743922136
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30749: [MINOR][UI] Correct JobPage's skipped/pending tableHeaderId
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30749:
URL: https://github.com/apache/spark/pull/30749#issuecomment-743963800
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37318/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org