You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nifi.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2015/05/01 16:57:06 UTC

[jira] [Commented] (NIFI-561) FileBasedClusterNodeFirewallTest should rely on JUnit / Maven norms for test files.

    [ https://issues.apache.org/jira/browse/NIFI-561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14523281#comment-14523281 ] 

ASF subversion and git services commented on NIFI-561:
------------------------------------------------------

Commit 73a368f861de76638daac6787eea310cd1010ba6 in incubator-nifi's branch refs/heads/develop from [~busbey]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-nifi.git;h=73a368f ]

NIFI-561: FileBasedClusterNodeFirewallTest should rely on JUnit / Maven norms for test files.

Signed-off-by: Mark Payne <ma...@hotmail.com>


> FileBasedClusterNodeFirewallTest should rely on JUnit / Maven norms for test files.
> -----------------------------------------------------------------------------------
>
>                 Key: NIFI-561
>                 URL: https://issues.apache.org/jira/browse/NIFI-561
>             Project: Apache NiFi
>          Issue Type: Task
>          Components: Core Framework
>    Affects Versions: 0.0.1
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>            Priority: Minor
>             Fix For: 0.1.0
>
>         Attachments: NIFI-561.1.patch.txt, NIFI-561.2.patch.txt
>
>
> Right now FileBasedClusterNodeFirewallTest sets up its own test directory and reads test files directly out of hte source tree.
> These are both undesirable
> * setting up a temp directory in java.io.tmp manually makes more work when we could use a junit tempdirectory (it also makes it more likely that we'll mess up parallel builds)
> * reading out of the source tree prevents adding in maven rules that process the test resources before the test (as opposed to reading them out of target/classes, where teh test resource handler will put the finished products).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)