You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by "Hari Shreedharan (Created) (JIRA)" <ji...@apache.org> on 2012/04/07 00:00:16 UTC

[jira] [Created] (FLUME-1109) Syslog sources need to be refactored

Syslog sources need to be refactored
------------------------------------

                 Key: FLUME-1109
                 URL: https://issues.apache.org/jira/browse/FLUME-1109
             Project: Flume
          Issue Type: Bug
          Components: Sinks+Sources
    Affects Versions: v1.1.0
            Reporter: Hari Shreedharan
            Assignee: Hari Shreedharan


There is data loss in the syslog source.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (FLUME-1109) Syslog sources need to be refactored

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FLUME-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249137#comment-13249137 ] 

jiraposter@reviews.apache.org commented on FLUME-1109:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4676/
-----------------------------------------------------------

Review request for Flume.


Summary
-------

Refactoring Syslog sources, to fix a bunch of data loss problems encountered. 


This addresses bug FLUME-1109.
    https://issues.apache.org/jira/browse/FLUME-1109


Diffs
-----

  flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java d78d27f 
  flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 34818f0 
  flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java ceb9ff1 
  flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUdpSource.java d1db49d 
  flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java PRE-CREATION 

Diff: https://reviews.apache.org/r/4676/diff


Testing
-------

Did a bunch of functional tests. Also added unit tests for SylogUtils.


Thanks,

Hari


                
> Syslog sources need to be refactored
> ------------------------------------
>
>                 Key: FLUME-1109
>                 URL: https://issues.apache.org/jira/browse/FLUME-1109
>             Project: Flume
>          Issue Type: Bug
>          Components: Sinks+Sources
>    Affects Versions: v1.1.0
>            Reporter: Hari Shreedharan
>            Assignee: Hari Shreedharan
>
> There is data loss in the syslog source.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (FLUME-1109) Syslog sources need to be refactored

Posted by "Hari Shreedharan (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FLUME-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hari Shreedharan updated FLUME-1109:
------------------------------------

    Attachment: FLUME-1109-1.patch
    
> Syslog sources need to be refactored
> ------------------------------------
>
>                 Key: FLUME-1109
>                 URL: https://issues.apache.org/jira/browse/FLUME-1109
>             Project: Flume
>          Issue Type: Bug
>          Components: Sinks+Sources
>    Affects Versions: v1.1.0
>            Reporter: Hari Shreedharan
>            Assignee: Hari Shreedharan
>         Attachments: FLUME-1109-1.patch
>
>
> There is data loss in the syslog source.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (FLUME-1109) Syslog sources need to be refactored

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FLUME-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249168#comment-13249168 ] 

Hudson commented on FLUME-1109:
-------------------------------

Integrated in flume-trunk #163 (See [https://builds.apache.org/job/flume-trunk/163/])
    FLUME-1109. Syslog source loses data under some situations.

(Hari Shreedharan via Arvind Prabhakar) (Revision 1310665)

     Result = SUCCESS
arvind : http://svn.apache.org/viewvc/?view=rev&rev=1310665
Files : 
* /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java
* /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java
* /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java
* /incubator/flume/trunk/flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUdpSource.java
* /incubator/flume/trunk/flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java

                
> Syslog sources need to be refactored
> ------------------------------------
>
>                 Key: FLUME-1109
>                 URL: https://issues.apache.org/jira/browse/FLUME-1109
>             Project: Flume
>          Issue Type: Bug
>          Components: Sinks+Sources
>    Affects Versions: v1.1.0
>            Reporter: Hari Shreedharan
>            Assignee: Hari Shreedharan
>             Fix For: v1.2.0
>
>         Attachments: FLUME-1109-1.patch
>
>
> There is data loss in the syslog source.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (FLUME-1109) Syslog sources need to be refactored

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FLUME-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249155#comment-13249155 ] 

jiraposter@reviews.apache.org commented on FLUME-1109:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4676/#review6765
-----------------------------------------------------------

Ship it!


+1

Thanks for the patch Hari.

- Arvind


On 2012-04-07 02:33:01, Hari Shreedharan wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4676/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-04-07 02:33:01)
bq.  
bq.  
bq.  Review request for Flume.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Refactoring Syslog sources, to fix a bunch of data loss problems encountered. 
bq.  
bq.  
bq.  This addresses bug FLUME-1109.
bq.      https://issues.apache.org/jira/browse/FLUME-1109
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java d78d27f 
bq.    flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 34818f0 
bq.    flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java ceb9ff1 
bq.    flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUdpSource.java d1db49d 
bq.    flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/4676/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Did a bunch of functional tests. Also added unit tests for SylogUtils.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Hari
bq.  
bq.


                
> Syslog sources need to be refactored
> ------------------------------------
>
>                 Key: FLUME-1109
>                 URL: https://issues.apache.org/jira/browse/FLUME-1109
>             Project: Flume
>          Issue Type: Bug
>          Components: Sinks+Sources
>    Affects Versions: v1.1.0
>            Reporter: Hari Shreedharan
>            Assignee: Hari Shreedharan
>         Attachments: FLUME-1109-1.patch
>
>
> There is data loss in the syslog source.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (FLUME-1109) Syslog sources need to be refactored

Posted by "Arvind Prabhakar (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FLUME-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arvind Prabhakar updated FLUME-1109:
------------------------------------

       Resolution: Fixed
    Fix Version/s: v1.2.0
           Status: Resolved  (was: Patch Available)

Patch committed. Thanks Hari!
                
> Syslog sources need to be refactored
> ------------------------------------
>
>                 Key: FLUME-1109
>                 URL: https://issues.apache.org/jira/browse/FLUME-1109
>             Project: Flume
>          Issue Type: Bug
>          Components: Sinks+Sources
>    Affects Versions: v1.1.0
>            Reporter: Hari Shreedharan
>            Assignee: Hari Shreedharan
>             Fix For: v1.2.0
>
>         Attachments: FLUME-1109-1.patch
>
>
> There is data loss in the syslog source.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (FLUME-1109) Syslog sources need to be refactored

Posted by "Hari Shreedharan (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FLUME-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hari Shreedharan updated FLUME-1109:
------------------------------------

    Status: Patch Available  (was: Open)
    
> Syslog sources need to be refactored
> ------------------------------------
>
>                 Key: FLUME-1109
>                 URL: https://issues.apache.org/jira/browse/FLUME-1109
>             Project: Flume
>          Issue Type: Bug
>          Components: Sinks+Sources
>    Affects Versions: v1.1.0
>            Reporter: Hari Shreedharan
>            Assignee: Hari Shreedharan
>         Attachments: FLUME-1109-1.patch
>
>
> There is data loss in the syslog source.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira