You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2019/10/17 12:50:00 UTC
[kudu-CR] [common] Exit the loop when there is nothing left to decode
lingbinlb@gmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14483
Change subject: [common] Exit the loop when there is nothing left to decode
......................................................................
[common] Exit the loop when there is nothing left to decode
Change-Id: I74c62c02e4e547831d3213dc0e7d9704d53d9bb6
---
M src/kudu/common/partition.cc
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/14483/1
--
To view, visit http://gerrit.cloudera.org:8080/14483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I74c62c02e4e547831d3213dc0e7d9704d53d9bb6
Gerrit-Change-Number: 14483
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <li...@gmail.com>
[kudu-CR] [common] Exit the loop when there is nothing left to decode
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
lingbinlb@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/14483 )
Change subject: [common] Exit the loop when there is nothing left to decode
......................................................................
Patch Set 1:
> Patch Set 1: Verified-1
>
> Build Failed
>
> http://jenkins.kudu.apache.org/job/kudu-gerrit/19180/ : FAILURE
It is an unrelated test failure
--
To view, visit http://gerrit.cloudera.org:8080/14483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I74c62c02e4e547831d3213dc0e7d9704d53d9bb6
Gerrit-Change-Number: 14483
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 17 Oct 2019 13:59:34 +0000
Gerrit-HasComments: No
[kudu-CR] [common] Exit the loop when there is nothing left to decode
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14483 )
Change subject: [common] Exit the loop when there is nothing left to decode
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/14483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I74c62c02e4e547831d3213dc0e7d9704d53d9bb6
Gerrit-Change-Number: 14483
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 17 Oct 2019 16:30:48 +0000
Gerrit-HasComments: No
[kudu-CR] [common] Exit the loop when there is nothing left to decode
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed a vote on this change.
Change subject: [common] Exit the loop when there is nothing left to decode
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/14483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I74c62c02e4e547831d3213dc0e7d9704d53d9bb6
Gerrit-Change-Number: 14483
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [common] Exit the loop when there is nothing left to decode
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14483 )
Change subject: [common] Exit the loop when there is nothing left to decode
......................................................................
[common] Exit the loop when there is nothing left to decode
Change-Id: I74c62c02e4e547831d3213dc0e7d9704d53d9bb6
Reviewed-on: http://gerrit.cloudera.org:8080/14483
Reviewed-by: Bankim Bhavsar <ba...@cloudera.com>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/common/partition.cc
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Bankim Bhavsar: Looks good to me, but someone else must approve
Adar Dembo: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/14483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I74c62c02e4e547831d3213dc0e7d9704d53d9bb6
Gerrit-Change-Number: 14483
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [common] Exit the loop when there is nothing left to decode
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14483 )
Change subject: [common] Exit the loop when there is nothing left to decode
......................................................................
Patch Set 1: Verified+1 Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I74c62c02e4e547831d3213dc0e7d9704d53d9bb6
Gerrit-Change-Number: 14483
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 17 Oct 2019 18:18:52 +0000
Gerrit-HasComments: No