[GitHub] [hudi] KnightChess commented on a diff in pull request #6916: [HUDI-5003] Fix the type of InLineFileSystem`startOffset to long

[GitBox <gi...@apache.org>]

KnightChess commented on code in PR #6916:
URL: https://github.com/apache/hudi/pull/6916#discussion_r992103084


##########
hudi-common/src/main/java/org/apache/hudi/common/fs/inline/InLineFsDataInputStream.java:
##########
@@ -33,11 +33,11 @@
  */
 public class InLineFsDataInputStream extends FSDataInputStream {
 
-  private final int startOffset;
+  private final long startOffset;
   private final FSDataInputStream outerStream;
   private final int length;
 
-  public InLineFsDataInputStream(int startOffset, FSDataInputStream outerStream, int length) throws IOException {
+  public InLineFsDataInputStream(long startOffset, FSDataInputStream outerStream, int length) throws IOException {

Review Comment:
   length too.



##########
hudi-common/src/main/java/org/apache/hudi/common/fs/inline/InLineFsDataInputStream.java:
##########
@@ -33,11 +33,11 @@
  */
 public class InLineFsDataInputStream extends FSDataInputStream {
 
-  private final int startOffset;
+  private final long startOffset;
   private final FSDataInputStream outerStream;
   private final int length;

Review Comment:
   length need be `long` too



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org