You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/03/29 10:17:56 UTC
[GitHub] [beam] bullet03 opened a new pull request #17205: Beam 14145 add carousel to homepage
bullet03 opened a new pull request #17205:
URL: https://github.com/apache/beam/pull/17205
[Beam 14145]
- modify html, js, css of keen-slider
- add carousel to homepage
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] dariabezkorovaina edited a comment on pull request #17205: Beam 14145 add carousel to homepage
Posted by GitBox <gi...@apache.org>.
dariabezkorovaina edited a comment on pull request #17205:
URL: https://github.com/apache/beam/pull/17205#issuecomment-1085033716
@bullet03 @AydarZaynutdinov please double-check how the rotation works - we have 5 cards and 5 dots, if there are 3 cards per screen there are supposed to be 2 dots - clicking on one dot changes the view completely and rotates all cards on screen. Also, please check eBay and Dataflow, they are duplicated when rotating. Pls check the sample sites for reference on how dot rotation should work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] bullet03 commented on pull request #17205: Beam 14145 add carousel to homepage
Posted by GitBox <gi...@apache.org>.
bullet03 commented on pull request #17205:
URL: https://github.com/apache/beam/pull/17205#issuecomment-1081693287
R: @AydarZaynutdinov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] dariabezkorovaina commented on pull request #17205: Beam 14145 add carousel to homepage
Posted by GitBox <gi...@apache.org>.
dariabezkorovaina commented on pull request #17205:
URL: https://github.com/apache/beam/pull/17205#issuecomment-1085033716
@bullet03 @AydarZaynutdinov please double-check how the rotation works - we have 5 cards and 5 dots, if there are 3 cards per screen there are supposed to be 2 dots - clicking on one dot changes the view completely and rotates all cards on screen. Also, please check eBay and Dataflow, they are are duplicated. Pls check the sample sites for reference on how dot rotation should work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org