You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/09/29 11:19:29 UTC
[GitHub] [cordova-android] mosabab opened a new pull request #1079: [Frequent Updates] Gradle to v6.6.1 & Android Gradle Plugin to 4.0.1
mosabab opened a new pull request #1079:
URL: https://github.com/apache/cordova-android/pull/1079
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
As Android Gradle plugin release notes https://developer.android.com/studio/releases/gradle-plugin#updating-gradle
Related to Gradle version and Android Gradle Plugin
Updates:
- Gradle version to 6.6.1
- Android Gradle Plugin version to 4.0.1
- GradlePluginKotlinVersion to 1.4.10
- com.jfrog.bintray.gradle to 1.8.5
### Description
<!-- Describe your changes in detail -->
### Testing
<!-- Please describe in detail how you tested your changes. -->
### Checklist
- [ ] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] mosabab commented on pull request #1079: [Frequent Updates] Gradle 6.6.1 & Android Gradle Plugin 4.0.1 & com.jfrog.bintray.gradle 1.8.5
Posted by GitBox <gi...@apache.org>.
mosabab commented on pull request #1079:
URL: https://github.com/apache/cordova-android/pull/1079#issuecomment-703615703
@breautek @timbru31
I revert the kotlin as previous to 1.3.50
And keep the gradle version to 6.6.1
And google plugin gradle version to 4.0.1
Could you please review it now
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] timbru31 commented on a change in pull request #1079: [Frequent Updates] Gradle to v6.6.1 & Android Gradle Plugin to 4.0.1
Posted by GitBox <gi...@apache.org>.
timbru31 commented on a change in pull request #1079:
URL: https://github.com/apache/cordova-android/pull/1079#discussion_r499556966
##########
File path: bin/templates/project/build.gradle
##########
@@ -19,13 +19,13 @@
// Top-level build file where you can add configuration options common to all sub-projects/modules.
buildscript {
- ext.kotlin_version = '1.3.50'
+ ext.kotlin_version = '1.4.10'
Review comment:
Personally I don't mind updating the complete toolset in one PR, but one could argue that it either should be listed in the PR ~description and~ title or updated in a separate PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] breautek commented on a change in pull request #1079: [Frequent Updates] Gradle 6.6.1 & Android Gradle Plugin 4.0.1 & GradlePluginKotlinVersion 1.4.10 & com.jfrog.bintray.gradle 1.8.5
Posted by GitBox <gi...@apache.org>.
breautek commented on a change in pull request #1079:
URL: https://github.com/apache/cordova-android/pull/1079#discussion_r499565418
##########
File path: bin/templates/project/build.gradle
##########
@@ -19,13 +19,13 @@
// Top-level build file where you can add configuration options common to all sub-projects/modules.
buildscript {
- ext.kotlin_version = '1.3.50'
+ ext.kotlin_version = '1.4.10'
Review comment:
Google does not follow traditional semver rules and minor releases can include breaking changes, therefore we cannot upgrade the minor version of Kotlin without also introducing a breaking change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] breautek merged pull request #1079: [Frequent Updates] Gradle 6.6.1 & Android Gradle Plugin 4.0.1 & com.jfrog.bintray.gradle 1.8.5
Posted by GitBox <gi...@apache.org>.
breautek merged pull request #1079:
URL: https://github.com/apache/cordova-android/pull/1079
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] mosabab commented on a change in pull request #1079: [Frequent Updates] Gradle 6.6.1 & Android Gradle Plugin 4.0.1 & GradlePluginKotlinVersion 1.4.10 & com.jfrog.bintray.gradle 1.8.5
Posted by GitBox <gi...@apache.org>.
mosabab commented on a change in pull request #1079:
URL: https://github.com/apache/cordova-android/pull/1079#discussion_r499560046
##########
File path: bin/templates/project/build.gradle
##########
@@ -19,13 +19,13 @@
// Top-level build file where you can add configuration options common to all sub-projects/modules.
buildscript {
- ext.kotlin_version = '1.3.50'
+ ext.kotlin_version = '1.4.10'
Review comment:
Your idea is correct, but this PR update any related to Gradle, I update the title to all updates affected and also I put the details in description filed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] mosabab commented on pull request #1079: [Frequent Updates] Gradle to v6.6.1 & Android Gradle Plugin to 4.0.1
Posted by GitBox <gi...@apache.org>.
mosabab commented on pull request #1079:
URL: https://github.com/apache/cordova-android/pull/1079#issuecomment-700637753
@breautek
[INVITED TO REVIEW]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] timbru31 commented on a change in pull request #1079: [Frequent Updates] Gradle to v6.6.1 & Android Gradle Plugin to 4.0.1
Posted by GitBox <gi...@apache.org>.
timbru31 commented on a change in pull request #1079:
URL: https://github.com/apache/cordova-android/pull/1079#discussion_r499556966
##########
File path: bin/templates/project/build.gradle
##########
@@ -19,13 +19,13 @@
// Top-level build file where you can add configuration options common to all sub-projects/modules.
buildscript {
- ext.kotlin_version = '1.3.50'
+ ext.kotlin_version = '1.4.10'
Review comment:
Personally I don't mind updating the complete toolset in one PR, but one could argue that it either should be listed in the PR description and title or updated in a separate PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] breautek commented on pull request #1079: [Frequent Updates] Gradle 6.6.1 & Android Gradle Plugin 4.0.1 & com.jfrog.bintray.gradle 1.8.5
Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #1079:
URL: https://github.com/apache/cordova-android/pull/1079#issuecomment-703959262
Looks good to me, merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] mosabab commented on a change in pull request #1079: [Frequent Updates] Gradle 6.6.1 & Android Gradle Plugin 4.0.1 & com.jfrog.bintray.gradle 1.8.5
Posted by GitBox <gi...@apache.org>.
mosabab commented on a change in pull request #1079:
URL: https://github.com/apache/cordova-android/pull/1079#discussion_r499571993
##########
File path: bin/templates/project/build.gradle
##########
@@ -19,13 +19,13 @@
// Top-level build file where you can add configuration options common to all sub-projects/modules.
buildscript {
- ext.kotlin_version = '1.3.50'
+ ext.kotlin_version = '1.4.10'
Review comment:
I revert the kotlin version to 1.3.50.
And i Keep the Gradle version and android gradle plugin to the latest version to keep sync with Android studio.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] timbru31 commented on a change in pull request #1079: [Frequent Updates] Gradle to v6.6.1 & Android Gradle Plugin to 4.0.1
Posted by GitBox <gi...@apache.org>.
timbru31 commented on a change in pull request #1079:
URL: https://github.com/apache/cordova-android/pull/1079#discussion_r499556966
##########
File path: bin/templates/project/build.gradle
##########
@@ -19,13 +19,13 @@
// Top-level build file where you can add configuration options common to all sub-projects/modules.
buildscript {
- ext.kotlin_version = '1.3.50'
+ ext.kotlin_version = '1.4.10'
Review comment:
Personally I don't mind updating the complete toolset in one PR, but one could argue that either it's listed in the PR description and title or updated in a separate PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] breautek commented on pull request #1079: [Frequent Updates] Gradle 6.6.1 & Android Gradle Plugin 4.0.1 & com.jfrog.bintray.gradle 1.8.5
Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #1079:
URL: https://github.com/apache/cordova-android/pull/1079#issuecomment-703675543
I'll review later tonight after work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] mosabab commented on a change in pull request #1079: [Frequent Updates] Gradle 6.6.1 & Android Gradle Plugin 4.0.1 & GradlePluginKotlinVersion 1.4.10 & com.jfrog.bintray.gradle 1.8.5
Posted by GitBox <gi...@apache.org>.
mosabab commented on a change in pull request #1079:
URL: https://github.com/apache/cordova-android/pull/1079#discussion_r499571993
##########
File path: bin/templates/project/build.gradle
##########
@@ -19,13 +19,13 @@
// Top-level build file where you can add configuration options common to all sub-projects/modules.
buildscript {
- ext.kotlin_version = '1.3.50'
+ ext.kotlin_version = '1.4.10'
Review comment:
I revert the kotlin version to 1.3.50.
So the other should keep updated to dismiss the sync at android studio
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] mosabab commented on a change in pull request #1079: [Frequent Updates] Gradle 6.6.1 & Android Gradle Plugin 4.0.1 & GradlePluginKotlinVersion 1.4.10 & com.jfrog.bintray.gradle 1.8.5
Posted by GitBox <gi...@apache.org>.
mosabab commented on a change in pull request #1079:
URL: https://github.com/apache/cordova-android/pull/1079#discussion_r499560046
##########
File path: bin/templates/project/build.gradle
##########
@@ -19,13 +19,13 @@
// Top-level build file where you can add configuration options common to all sub-projects/modules.
buildscript {
- ext.kotlin_version = '1.3.50'
+ ext.kotlin_version = '1.4.10'
Review comment:
Your idea is correct, but this PR update anything related to Gradle, I update the title to all updates affected and also I put the details in description filed.
For this Gradle updates, it is good to keep it in one PR instead of separated PR, because the main idea to update anything related to Gradle.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org