[GitHub] [beam] lazylynx commented on a change in pull request #15417: [BEAM-12794] raise proper error from exc_info

[GitBox <gi...@apache.org>]

lazylynx commented on a change in pull request #15417:
URL: https://github.com/apache/beam/pull/15417#discussion_r707260351



##########
File path: sdks/python/apache_beam/utils/exception.py
##########
@@ -0,0 +1,43 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+from types import TracebackType
+from typing import Optional
+from typing import Tuple
+from typing import Type
+from typing import Union
+
+
+def raise_exception(
+    error_type: Type[BaseException],
+    value: Optional[Union[Tuple, BaseException]],
+    traceback: Optional[TracebackType]):
+  """
+  Raise Exception from exc_info.
+  Derived from `future.utils.raise_`
+  """
+  if isinstance(value, error_type):
+    exc = value
+  elif isinstance(value, tuple):

Review comment:
       It seems to be difficult to raise exceptions intentionally for the cases and also be difficult to add tests for them.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org