[GitHub] [incubator-nuttx-apps] patacongo commented on pull request #307: Revert "nshlib: remove the dependency of date on RTC"

[GitBox <gi...@apache.org>]

patacongo commented on pull request #307:
URL: https://github.com/apache/incubator-nuttx-apps/pull/307#issuecomment-649094081


   > 
   > 
   > I think the original intention of @anchao was really good because he tried to disable the 'date' command when DEFAULT_SMALL was defined, then it should reduces 3KB for those boards. However the side effect was that all boards which doesn't have DEFAULT_SMALL gained +3KB.
   
   It is best to revert the PR.  The origin conditions are the most correct.  If RTC is enabled then the date command really must be supported.  Otherwise, there is no way to manually set the RTC.  If the RTC is not enabled, then the date command may occasionally still serve some limited purpose and the option to enable it still available.
   
   Changing configurations by changing the default setting is almost always a very bad idea and should not in general be done.  IF if is done then, there must also be an accompanying change to modify all affected defconfig files.  Otherwise, you also change the behavior of every configuration.  We cannot permit that in the future.
   
   The best solution is to revert the PR.  The original was correct, the modification is not.  If there some reason to retain the modification (there is NOT), then there would also have to be a massive PR to change every defconfig file (except those few that set CONFIG_RTC).  There are 600 defconfig files.  NONE of them explicitly set CONFIG_NSHLIB_DISABLE_DATE.  35 of those set CONFIG_RTC=y and those all expect CONFIG_NSHLIB_DISABLE_DATE=n.  565 of them are currently broken because this PR:  Those ALL expect CONFIG_NSHLIB_DISABLE_DATE=y.  This PR screws them all.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org