You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2021/03/07 07:18:57 UTC

[GitHub] [openwhisk-deploy-kube] keithnull opened a new pull request #679: Add backquotes for file names in docs

keithnull opened a new pull request #679:
URL: https://github.com/apache/openwhisk-deploy-kube/pull/679


   Hi, I'm new to OpenWhisk 😄 
   
   When reading these docs to deploy OpenWhisk, I noticed the inconsistent use of backquotes for file names: sometimes it's `` `mycluster.yaml` ``  while sometimes it's just plain `mycluster.yaml`. I think the former looks better and thus make this PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk-deploy-kube] dgrove-oss merged pull request #679: Add backquotes for file names in docs

Posted by GitBox <gi...@apache.org>.
dgrove-oss merged pull request #679:
URL: https://github.com/apache/openwhisk-deploy-kube/pull/679


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk-deploy-kube] keithnull commented on pull request #679: Add backquotes for file names in docs

Posted by GitBox <gi...@apache.org>.
keithnull commented on pull request #679:
URL: https://github.com/apache/openwhisk-deploy-kube/pull/679#issuecomment-792231497


   BTW, I also noticed some other markdown formatting issues like redundant spaces, missing blank lines, and improper indentation. (Of course, with the help of a markdown plugin for VSCode.) 
   
   I didn't include them in this PR as I'm not sure whether it's necessary to make docs strictly well-formatted. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk-deploy-kube] dgrove-oss commented on pull request #679: Add backquotes for file names in docs

Posted by GitBox <gi...@apache.org>.
dgrove-oss commented on pull request #679:
URL: https://github.com/apache/openwhisk-deploy-kube/pull/679#issuecomment-792780341


   Thanks! Merged.  If you want to submit a PR to improve formatting, that would be fine.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [openwhisk-deploy-kube] rabbah commented on pull request #679: Add backquotes for file names in docs

Posted by GitBox <gi...@apache.org>.
rabbah commented on pull request #679:
URL: https://github.com/apache/openwhisk-deploy-kube/pull/679#issuecomment-792716381


   Thank you for this patch @keithnull 🎉 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org