[GitHub] [arrow] westonpace commented on issue #34908: [C++] Switching the column ordering of "segment key" and "hash key"

["westonpace (via GitHub)" <gi...@apache.org>]

westonpace commented on issue #34908:
URL: https://github.com/apache/arrow/issues/34908#issuecomment-1500355286

   I'm fine with this switch.  I had no idea which should come first so I left the relative ordering the same when I changed `measures | keys | segment_keys` to `keys | segment_keys | measures`.  However, your reasoning seems pretty solid to me.
   
   Another option, though trickier, would be to keep `keys` and `segment_keys` ordered as they were in the input schema.  So, for example, if the user has `a, b, c, d, e, f` and `a` and `c` are segment_keys and `b` is a `key` then you could have the output `a, b, c,`.
   
   As long as `time` was first in the input then `time` would be first in the output.  I'm +1 either way.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org