[GitHub] [tvm] PhilippvK commented on pull request #10941: TVMC: Add new text/relay frontend

[GitBox <gi...@apache.org>]

PhilippvK commented on PR #10941:
URL: https://github.com/apache/tvm/pull/10941#issuecomment-1185259036

   @areusch 
   
   > add a parameter which you have to pass for Relay models indicating the inputs
   
   I currently already use `--input-shapes` to get the input names, ignoring the provided shapes. Adding new flag for only the names would be somehow redundant in my opinion.
   
   > accept params.npz and treat everything not in there as inputs
   
   Would maybe be a good idea for the future, but I think this is out-of scope for this PR.
   
   > for (2), that seems like an oversight on Model Library Format part.
   
   The thing is that exporting the full relay model including metadata can result in very lang files which might not be desirable for the `relay.txt` in the MLF. However I would prefer some consistency here having at least the proper header in there. 
   
   > it seems like we should make tvmc validate the version numbers in relay models.
   
   I can look into this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org