You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by SuJinpei <gi...@git.apache.org> on 2017/07/05 11:15:29 UTC
[GitHub] incubator-trafodion pull request #1165: [TRAFODION-2677] odb load source wit...
GitHub user SuJinpei opened a pull request:
https://github.com/apache/incubator-trafodion/pull/1165
[TRAFODION-2677] odb load source with src=-file is failure
root cause: each thread try to call splitcso to get Catalog/Schema/Table from the same tgt buffer, but splitcso will modify tgt buffer, so only one thread can get the correct result.
fix way: 1. Catalog/Schema/Table can be determined when creating etab, so move it forward.
2. etab[*].tgt is used elsewhere and is assumed not split, so make a copy of tgt.
3. add globalPointers to save pointers to buffers which may be shared by many thread and length determined at run time.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SuJinpei/incubator-trafodion Trafodion-2677
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/1165.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1165
----
commit ee497fe94d5e6e7ca24657288fbc62f47a9e4e17
Author: SuJinpei <87...@qq.com>
Date: 2017-07-05T01:52:44Z
[TRAFODION-2677] odb load source with src=-file is falure
commit ecc76bd45282008d7ea45e4bea4090a6d3616bcd
Author: SuJinpei <87...@qq.com>
Date: 2017-07-05T10:10:32Z
fix TRAFODION-2677
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #1165: [TRAFODION-2677] odb load source wit...
Posted by SuJinpei <gi...@git.apache.org>.
GitHub user SuJinpei reopened a pull request:
https://github.com/apache/incubator-trafodion/pull/1165
[TRAFODION-2677] odb load source with src=-file is failure
root cause: each thread try to call splitcso to get Catalog/Schema/Table from the same tgt buffer, but splitcso will modify tgt buffer, so only one thread can get the correct result.
fix way: 1. Catalog/Schema/Table can be determined when creating etab, so move it forward.
2. etab[*].tgt is used elsewhere and is assumed not split, so make a copy of tgt.
3. add globalPointers to save pointers to buffers which may be shared by many thread and length determined at run time.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SuJinpei/incubator-trafodion Trafodion-2677
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/1165.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1165
----
commit ee497fe94d5e6e7ca24657288fbc62f47a9e4e17
Author: SuJinpei <87...@qq.com>
Date: 2017-07-05T01:52:44Z
[TRAFODION-2677] odb load source with src=-file is falure
commit ecc76bd45282008d7ea45e4bea4090a6d3616bcd
Author: SuJinpei <87...@qq.com>
Date: 2017-07-05T10:10:32Z
fix TRAFODION-2677
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #1165: [TRAFODION-2677] odb load source wit...
Posted by SuJinpei <gi...@git.apache.org>.
Github user SuJinpei closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/1165
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #1165: [TRAFODION-2677] odb load source wit...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/1165
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---