You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@helix.apache.org by "Hunter L (JIRA)" <ji...@apache.org> on 2018/10/29 23:51:02 UTC

[jira] [Created] (HELIX-770) HELIX: Fix a possible NPE in loadBalance in IntermediateStateCalcStage

Hunter L created HELIX-770:
------------------------------

             Summary: HELIX: Fix a possible NPE in loadBalance in IntermediateStateCalcStage
                 Key: HELIX-770
                 URL: https://issues.apache.org/jira/browse/HELIX-770
             Project: Apache Helix
          Issue Type: Improvement
            Reporter: Hunter L
            Assignee: Hunter L


In isLoadBalanceDownwardForAllReplicas() in IntermediateStateCalcStage, statePriorityMap was throwing a NPE because the partition contained a replica in ERROR state, and the map did not have an entry for it. To amend the issue, Venice added the ERROR state in the state model with a priority, and Helix added checks to prevent NPEs. Changelist: 1. Add containsKey checks in isLoadBalanceDownwardForAllReplicas() 2. Make the Controller correctly log all partitions with ERROR state replicas 3. Add HelixDefinedStates in statePriorityList if not already added



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)