[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #731: WIP: MINIFICPP-1096 fix BackTrace, OOB indexing, tests, appveyor reporting

[GitBox <gi...@apache.org>]

arpadboda commented on a change in pull request #731: WIP: MINIFICPP-1096 fix BackTrace, OOB indexing, tests, appveyor reporting
URL: https://github.com/apache/nifi-minifi-cpp/pull/731#discussion_r381332868
 
 

 ##########
 File path: libminifi/include/utils/file/FileUtils.h
 ##########
 @@ -112,31 +112,33 @@ class FileUtils {
 #endif
   }
 
-  static std::string create_temp_directory(char *format) {
+  static std::string create_temp_directory(const char * const format) {
 
 Review comment:
   As it's test code and I think nobody has ever made anything that depended on the modified buffer, I'm fine with this. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services