[jira] [Commented] (CLOUDSTACK-8870) external network device usage monitor runs even when there are no external devices

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15108493#comment-15108493 ] 

ASF GitHub Bot commented on CLOUDSTACK-8870:
--------------------------------------------

Github user wilderrodrigues commented on the pull request:

    https://github.com/apache/cloudstack/pull/846#issuecomment-173198529
  
    Ping @remibergsma @borisroman 
    
    @kishankavala added a unit test to cover his change. I went through the code and haven't found any issue.
    
    The if block ```if(_hostDao.listByType(Host.Type.ExternalFirewall).isEmpty() && _hostDao.listByType(Host.Type.ExternalLoadBalancer).isEmpty()){``` added to ExternalDeviceUsageManagerImpl make sense and are covered.
    
    Please give it a go with the integration tests we have.
    
    Cheers,
    Wilder


> external network device usage monitor runs even when there are no external devices
> ----------------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-8870
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8870
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Kishan Kavala
>            Assignee: Kishan Kavala
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)