[jira] [Commented] (CAMEL-10460) MetricsMessageHistoryFactory.java:138 Generate a NPE

["Philippe Godot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CAMEL-10460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15651383#comment-15651383 ] 

Philippe Godot commented on CAMEL-10460:
----------------------------------------

For my point of view, problem could comes from ProcessorDefinitionHelper which is manage getRouteId which is working only for RouteDefinition object, but exception routes are of type OnExceptionDefinition and then this method return null. 

> MetricsMessageHistoryFactory.java:138 Generate a NPE
> ----------------------------------------------------
>
>                 Key: CAMEL-10460
>                 URL: https://issues.apache.org/jira/browse/CAMEL-10460
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-metrics
>    Affects Versions: 2.18.0
>         Environment: MacOs, JDK 1.8, SpringBoot 1.4.1, Spring Metrics
>            Reporter: Philippe Godot
>
> I'm trying to play with Spring-boot camel and metrics to expose dashboard. 
> Hawtio is a great tools to check what it's going on at runtime but no persistence is done. We would like to persist statistics in prometheus by example. 
> I configure camel context with MetricsMessageHistoryFactory as: 
>     MetricsMessageHistoryFactory metricsMessageHistoryFactory = new MetricsMessageHistoryFactory(); 
>     metricsMessageHistoryFactory.setMetricsRegistry(metricRegistry); 
>     camelContext.setMessageHistoryFactory(metricsMessageHistoryFactory); 
> where metricRegistry is injected with: 
>   /** 
>    * Srping Boot metrics 
>    */ 
>   @Autowired 
>   private MetricRegistry metricRegistry; 
> Everything is ok until I passed in OnExceptionRoute. It seems that the routeId is set to Null in this case and generate a NPE (line MetricsMessageHistoryFactory:138) in the exception route. Route causing the NPE:
> onException(NoAttachmentToProcessException.class) 
>         .routeId(RouteIds.TECHNICAL_ERROR_HANDLING.routeId()) 
>         .log(LoggingLevel.ERROR,"TECHNICAL ERROR: ${exchangeProperty.CamelExceptionCaught}") 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)