[GitHub] [spark] MaxGekk commented on a change in pull request #33258: [SPARK-36037][SQL] Support new function localtimestamp()

[GitBox <gi...@apache.org>]

MaxGekk commented on a change in pull request #33258:
URL: https://github.com/apache/spark/pull/33258#discussion_r666974495



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/finishAnalysis.scala
##########
@@ -91,6 +94,7 @@ object ComputeCurrentTime extends Rule[LogicalPlan] {
         })
       case CurrentTimestamp() | Now() => currentTime
       case CurrentTimeZone() => timezone
+      case LocalTimestamp() => localTime

Review comment:
       > I don't see much difference
   
   @gengliangwang The difference is in that you don't need to especially handle `LocalTimestamp()` here, for instance, and maybe in other places.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org