[GitHub] [ignite] alievmirza commented on a change in pull request #9004: IGNITE-14474 expand log for errors with GridDhtPartitionSupplyMessage in GridDhtPartitionDemander

[GitBox <gi...@apache.org>]

alievmirza commented on a change in pull request #9004:
URL: https://github.com/apache/ignite/pull/9004#discussion_r630261925



##########
File path: modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/rebalancing/GridCacheRebalancingUnmarshallingFailedSelfTest.java
##########
@@ -41,14 +44,21 @@
  */
 public class GridCacheRebalancingUnmarshallingFailedSelfTest extends GridCommonAbstractTest {
     /** partitioned cache name. */
-    protected static String CACHE = "cache";
+    protected static final String CACHE = "cache";
 
     /** Allows to change behavior of readExternal method. */
     protected static AtomicInteger readCnt = new AtomicInteger();
 
     /** */
     private volatile Marshaller marshaller;
 
+    /** */
+    private ListeningTestLogger customLog;
+
+    /** */
+    private static final Pattern unmarshalingErrorPattern = Pattern.compile(".*Rebalancing routine has failed" +

Review comment:
       Not a conventional name for the static final field. Please use uppercase 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org