[jira] [Commented] (FLINK-8419) Kafka consumer's offset metrics are not registered for dynamically discovered partitions

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-8419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16354358#comment-16354358 ] 

ASF GitHub Bot commented on FLINK-8419:
---------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5335


> Kafka consumer's offset metrics are not registered for dynamically discovered partitions
> ----------------------------------------------------------------------------------------
>
>                 Key: FLINK-8419
>                 URL: https://issues.apache.org/jira/browse/FLINK-8419
>             Project: Flink
>          Issue Type: Bug
>          Components: Kafka Connector, Metrics
>    Affects Versions: 1.4.0, 1.5.0
>            Reporter: Tzu-Li (Gordon) Tai
>            Assignee: Tzu-Li (Gordon) Tai
>            Priority: Blocker
>             Fix For: 1.5.0, 1.4.1
>
>
> Currently, the per-partition offset metrics are registered via the {{AbstractFetcher#addOffsetStateGauge}} method. That method is only ever called for the initial startup partitions, and not for dynamically discovered partitions.
> We should consider adding some unit tests to make sure that metrics are properly registered for all partitions. That would also safeguard us from accidentally removing metrics.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)