You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by Pascal Sancho <ps...@gmail.com> on 2012/10/24 16:03:26 UTC

Re: svn commit: r1401607 [1/3] - in /xmlgraphics/fop/trunk: ./ examples/fo/advanced/ src/documentation/intermediate-format-ng/ src/java/org/apache/fop/afp/ src/java/org/apache/fop/area/ src/java/org/apache/fop/fo/ src/java/org/apache/fop/fo/extension

Hi,

This merge seems introduce 3 deprecated warning.
I'm not sure, but it is possible that UnitConv has migrated to
xmlgraphics.commons



compile-java:
    [mkdir] Created dir: D:\bin\java\fop\trunk\build\classes
    [javac] Compiling 1441 source files to D:\bin\java\fop\trunk\build\classes
    [javac] D:\bin\java\fop\trunk\src\java\org\apache\fop\render\AbstractPathOrientedRenderer.java:52:
warning: [deprecation] org.apache.fop.util.UnitConv in
org.apache.fop.util has been deprecated
    [javac] import org.apache.fop.util.UnitConv;
    [javac]                           ^
    [javac] D:\bin\java\fop\trunk\src\java\org\apache\fop\render\AbstractPathOrientedRenderer.java:999:
warning: [deprecation] org.apache.fop.util.UnitConv in
org.apache.fop.util has been deprecated
    [javac]         concatenateTransformationMatrix(UnitConv.mptToPt(at));
    [javac]                                         ^
    [javac] D:\bin\java\fop\trunk\src\java\org\apache\fop\render\AbstractPathOrientedRenderer.java:999:
warning: [deprecation] mptToPt(java.awt.geom.AffineTransform) in
org.apache.fop.util.UnitConv has been deprecated
    [javac]         concatenateTransformationMatrix(UnitConv.mptToPt(at));
    [javac]                                                 ^
    [javac] Note: Some input files use unchecked or unsafe operations.
    [javac] Note: Recompile with -Xlint:unchecked for details.
    [javac] 3 warnings


2012/10/24  <ph...@apache.org>:
> Author: phancock
> Date: Wed Oct 24 10:20:17 2012
> New Revision: 1401607
>
> URL: http://svn.apache.org/viewvc?rev=1401607&view=rev
> Log:
> Added support for Rounded Corners (see Bugzilla 54041).
>
> Contributions made by PH, JM and LB
> (...)

-- 
pascal

Re: svn commit: r1401607 [1/3] - in /xmlgraphics/fop/trunk: ./ examples/fo/advanced/ src/documentation/intermediate-format-ng/ src/java/org/apache/fop/afp/ src/java/org/apache/fop/area/ src/java/org/apache/fop/fo/ src/java/org/apache/fop/fo/extension

Posted by Pascal Sancho <ps...@gmail.com>.
Hi Peter,

good job, anyway.
Tests are ok for now (except a "0 run" for Testsuite:
org.apache.fop.image.loader.batik.ImageLoaderTestCase -- ;-) I guess
this is not related to rounded corners).

2012/10/30 Peter Hancock <pe...@gmail.com>:
> Well spotted Pascal and sorry for the late reply.
>
> This was introduced in error during a merge - I am guessing my IDE
> generated the import statement, choosing the version of the class in
> FOP - I really should have spotted this!
>
>  I have fixed this in the trunk and I have no other reason to believe
> there are any other regressions.
>
> Thanks,
>
> Peter
>
> On Thu, Oct 25, 2012 at 9:21 AM, Pascal Sancho <ps...@gmail.com> wrote:
>> Hi,
>>
>> it appears that the change from r687369 is lost (replacing
>> org.apache.fop.util.UnitConv with
>> org.apache.xmlgraphics.util.UnitConv).
>>
>> This regression starts with the branch (r1003017), so I guess it was
>> branched from a local modified WC.
>> I think that this merge should be reverted, and the branch should be
>> checked, regarding all changes introduced during the branch creation,
>> I suspect other potential regressions.
>>
>> 2012/10/24 Pascal Sancho <ps...@gmail.com>:
>>> Hi,
>>>
>>> This merge seems introduce 3 deprecated warning.
>>> I'm not sure, but it is possible that UnitConv has migrated to
>>> xmlgraphics.commons
>>>
>>>
>>>
>>> compile-java:
>>>     [mkdir] Created dir: D:\bin\java\fop\trunk\build\classes
>>>     [javac] Compiling 1441 source files to D:\bin\java\fop\trunk\build\classes
>>>     [javac] D:\bin\java\fop\trunk\src\java\org\apache\fop\render\AbstractPathOrientedRenderer.java:52:
>>> warning: [deprecation] org.apache.fop.util.UnitConv in
>>> org.apache.fop.util has been deprecated
>>>     [javac] import org.apache.fop.util.UnitConv;
>>>     [javac]                           ^
>>>     [javac] D:\bin\java\fop\trunk\src\java\org\apache\fop\render\AbstractPathOrientedRenderer.java:999:
>>> warning: [deprecation] org.apache.fop.util.UnitConv in
>>> org.apache.fop.util has been deprecated
>>>     [javac]         concatenateTransformationMatrix(UnitConv.mptToPt(at));
>>>     [javac]                                         ^
>>>     [javac] D:\bin\java\fop\trunk\src\java\org\apache\fop\render\AbstractPathOrientedRenderer.java:999:
>>> warning: [deprecation] mptToPt(java.awt.geom.AffineTransform) in
>>> org.apache.fop.util.UnitConv has been deprecated
>>>     [javac]         concatenateTransformationMatrix(UnitConv.mptToPt(at));
>>>     [javac]                                                 ^
>>>     [javac] Note: Some input files use unchecked or unsafe operations.
>>>     [javac] Note: Recompile with -Xlint:unchecked for details.
>>>     [javac] 3 warnings
>>>
>>>
>>> 2012/10/24  <ph...@apache.org>:
>>>> Author: phancock
>>>> Date: Wed Oct 24 10:20:17 2012
>>>> New Revision: 1401607
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=1401607&view=rev
>>>> Log:
>>>> Added support for Rounded Corners (see Bugzilla 54041).
>>>>
>>>> Contributions made by PH, JM and LB
>>>> (...)


-- 
pascal

Re: svn commit: r1401607 [1/3] - in /xmlgraphics/fop/trunk: ./ examples/fo/advanced/ src/documentation/intermediate-format-ng/ src/java/org/apache/fop/afp/ src/java/org/apache/fop/area/ src/java/org/apache/fop/fo/ src/java/org/apache/fop/fo/extension

Posted by Peter Hancock <pe...@gmail.com>.
Well spotted Pascal and sorry for the late reply.

This was introduced in error during a merge - I am guessing my IDE
generated the import statement, choosing the version of the class in
FOP - I really should have spotted this!

 I have fixed this in the trunk and I have no other reason to believe
there are any other regressions.

Thanks,

Peter

On Thu, Oct 25, 2012 at 9:21 AM, Pascal Sancho <ps...@gmail.com> wrote:
> Hi,
>
> it appears that the change from r687369 is lost (replacing
> org.apache.fop.util.UnitConv with
> org.apache.xmlgraphics.util.UnitConv).
>
> This regression starts with the branch (r1003017), so I guess it was
> branched from a local modified WC.
> I think that this merge should be reverted, and the branch should be
> checked, regarding all changes introduced during the branch creation,
> I suspect other potential regressions.
>
> 2012/10/24 Pascal Sancho <ps...@gmail.com>:
>> Hi,
>>
>> This merge seems introduce 3 deprecated warning.
>> I'm not sure, but it is possible that UnitConv has migrated to
>> xmlgraphics.commons
>>
>>
>>
>> compile-java:
>>     [mkdir] Created dir: D:\bin\java\fop\trunk\build\classes
>>     [javac] Compiling 1441 source files to D:\bin\java\fop\trunk\build\classes
>>     [javac] D:\bin\java\fop\trunk\src\java\org\apache\fop\render\AbstractPathOrientedRenderer.java:52:
>> warning: [deprecation] org.apache.fop.util.UnitConv in
>> org.apache.fop.util has been deprecated
>>     [javac] import org.apache.fop.util.UnitConv;
>>     [javac]                           ^
>>     [javac] D:\bin\java\fop\trunk\src\java\org\apache\fop\render\AbstractPathOrientedRenderer.java:999:
>> warning: [deprecation] org.apache.fop.util.UnitConv in
>> org.apache.fop.util has been deprecated
>>     [javac]         concatenateTransformationMatrix(UnitConv.mptToPt(at));
>>     [javac]                                         ^
>>     [javac] D:\bin\java\fop\trunk\src\java\org\apache\fop\render\AbstractPathOrientedRenderer.java:999:
>> warning: [deprecation] mptToPt(java.awt.geom.AffineTransform) in
>> org.apache.fop.util.UnitConv has been deprecated
>>     [javac]         concatenateTransformationMatrix(UnitConv.mptToPt(at));
>>     [javac]                                                 ^
>>     [javac] Note: Some input files use unchecked or unsafe operations.
>>     [javac] Note: Recompile with -Xlint:unchecked for details.
>>     [javac] 3 warnings
>>
>>
>> 2012/10/24  <ph...@apache.org>:
>>> Author: phancock
>>> Date: Wed Oct 24 10:20:17 2012
>>> New Revision: 1401607
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1401607&view=rev
>>> Log:
>>> Added support for Rounded Corners (see Bugzilla 54041).
>>>
>>> Contributions made by PH, JM and LB
>>> (...)
>
> --
> pascal

Re: svn commit: r1401607 [1/3] - in /xmlgraphics/fop/trunk: ./ examples/fo/advanced/ src/documentation/intermediate-format-ng/ src/java/org/apache/fop/afp/ src/java/org/apache/fop/area/ src/java/org/apache/fop/fo/ src/java/org/apache/fop/fo/extension

Posted by Pascal Sancho <ps...@gmail.com>.
Hi,

it appears that the change from r687369 is lost (replacing
org.apache.fop.util.UnitConv with
org.apache.xmlgraphics.util.UnitConv).

This regression starts with the branch (r1003017), so I guess it was
branched from a local modified WC.
I think that this merge should be reverted, and the branch should be
checked, regarding all changes introduced during the branch creation,
I suspect other potential regressions.

2012/10/24 Pascal Sancho <ps...@gmail.com>:
> Hi,
>
> This merge seems introduce 3 deprecated warning.
> I'm not sure, but it is possible that UnitConv has migrated to
> xmlgraphics.commons
>
>
>
> compile-java:
>     [mkdir] Created dir: D:\bin\java\fop\trunk\build\classes
>     [javac] Compiling 1441 source files to D:\bin\java\fop\trunk\build\classes
>     [javac] D:\bin\java\fop\trunk\src\java\org\apache\fop\render\AbstractPathOrientedRenderer.java:52:
> warning: [deprecation] org.apache.fop.util.UnitConv in
> org.apache.fop.util has been deprecated
>     [javac] import org.apache.fop.util.UnitConv;
>     [javac]                           ^
>     [javac] D:\bin\java\fop\trunk\src\java\org\apache\fop\render\AbstractPathOrientedRenderer.java:999:
> warning: [deprecation] org.apache.fop.util.UnitConv in
> org.apache.fop.util has been deprecated
>     [javac]         concatenateTransformationMatrix(UnitConv.mptToPt(at));
>     [javac]                                         ^
>     [javac] D:\bin\java\fop\trunk\src\java\org\apache\fop\render\AbstractPathOrientedRenderer.java:999:
> warning: [deprecation] mptToPt(java.awt.geom.AffineTransform) in
> org.apache.fop.util.UnitConv has been deprecated
>     [javac]         concatenateTransformationMatrix(UnitConv.mptToPt(at));
>     [javac]                                                 ^
>     [javac] Note: Some input files use unchecked or unsafe operations.
>     [javac] Note: Recompile with -Xlint:unchecked for details.
>     [javac] 3 warnings
>
>
> 2012/10/24  <ph...@apache.org>:
>> Author: phancock
>> Date: Wed Oct 24 10:20:17 2012
>> New Revision: 1401607
>>
>> URL: http://svn.apache.org/viewvc?rev=1401607&view=rev
>> Log:
>> Added support for Rounded Corners (see Bugzilla 54041).
>>
>> Contributions made by PH, JM and LB
>> (...)

-- 
pascal