You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by wengyanqing <gi...@git.apache.org> on 2016/02/22 02:16:36 UTC
[GitHub] incubator-hawq pull request: HAWQ-428. ORDER/GROUP BY not found in...
GitHub user wengyanqing opened a pull request:
https://github.com/apache/incubator-hawq/pull/364
HAWQ-428. ORDER/GROUP BY not found in target list error found in olap…
ignore error if fail in get_sortgroupclause_tle function when check targetentry in rollup. Because rollup clause only need groupkeys.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wengyanqing/incubator-hawq rollup_bugfix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/364.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #364
----
commit 7aa518e31f415087792c7043d722a82a899720eb
Author: ivan <iw...@pivotal.io>
Date: 2016-02-22T01:09:42Z
HAWQ-428. ORDER/GROUP BY not found in target list error found in olap query
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-428. ORDER/GROUP BY not found in...
Posted by zhangh43 <gi...@git.apache.org>.
Github user zhangh43 commented on the pull request:
https://github.com/apache/incubator-hawq/pull/364#issuecomment-186960743
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-428. ORDER/GROUP BY not found in...
Posted by wengyanqing <gi...@git.apache.org>.
Github user wengyanqing closed the pull request at:
https://github.com/apache/incubator-hawq/pull/364
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-428. ORDER/GROUP BY not found in...
Posted by zhangh43 <gi...@git.apache.org>.
Github user zhangh43 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/364#discussion_r53578942
--- Diff: src/backend/optimizer/plan/plangroupext.c ---
@@ -1867,7 +1867,12 @@ convert_gs_to_rollups(AttrNumber *grpColIdx,
* resno.
*/
sc.tleSortGroupRef = no+1;
- tle = get_sortgroupclause_tle(&sc, tlist);
+ tle = get_sortgroupclause_tle_internal(&sc, tlist);
--- End diff --
neet to format here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---