You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/12/10 14:26:46 UTC
[GitHub] [rocketmq] haozhijie9527 opened a new issue #3624: DefaultMQPushConsumerTest.testPullMessage_ExceptionOccursWhenComputePullFromWhere throws RejectedExecution
haozhijie9527 opened a new issue #3624:
URL: https://github.com/apache/rocketmq/issues/3624
After merge ISSUE #3453 ,DefaultMQPushConsumerTest.testPullMessage_ExceptionOccursWhenComputePullFromWhere throws RejectedExecution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] haozhijie9527 edited a comment on issue #3624: DefaultMQPushConsumerTest.testPullMessage_ExceptionOccursWhenComputePullFromWhere throws RejectedExecution
Posted by GitBox <gi...@apache.org>.
haozhijie9527 edited a comment on issue #3624:
URL: https://github.com/apache/rocketmq/issues/3624#issuecomment-992224840
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] areyouok commented on issue #3624: DefaultMQPushConsumerTest.testPullMessage_ExceptionOccursWhenComputePullFromWhere throws RejectedExecution
Posted by GitBox <gi...@apache.org>.
areyouok commented on issue #3624:
URL: https://github.com/apache/rocketmq/issues/3624#issuecomment-992610961
I think there is no problem.
And I sugguest restore the unit test code to original version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] haozhijie9527 edited a comment on issue #3624: DefaultMQPushConsumerTest.testPullMessage_ExceptionOccursWhenComputePullFromWhere throws RejectedExecution
Posted by GitBox <gi...@apache.org>.
haozhijie9527 edited a comment on issue #3624:
URL: https://github.com/apache/rocketmq/issues/3624#issuecomment-992224840
@panzhi33 @yuz10 This problem still exists, and will cause the consumers we deploy in the production environment to fail to start
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] areyouok edited a comment on issue #3624: DefaultMQPushConsumerTest.testPullMessage_ExceptionOccursWhenComputePullFromWhere throws RejectedExecution
Posted by GitBox <gi...@apache.org>.
areyouok edited a comment on issue #3624:
URL: https://github.com/apache/rocketmq/issues/3624#issuecomment-992420954
> @haozhijie9527 @areyouok Please help to check again
The synchronized block in RequestFutureHolder is not safe enough. Concurrent problem still exists.
I sugguest move DefaultMQProducerImpl.startScheduledTask() and
```
if (RequestFutureHolder.getInstance().getProducerNum().decrementAndGet() == 0) {
RequestFutureHolder.getInstance().getScheduledExecutorService().shutdown();
}
```
to RequestFutureHolder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] haozhijie9527 commented on issue #3624: DefaultMQPushConsumerTest.testPullMessage_ExceptionOccursWhenComputePullFromWhere throws RejectedExecution
Posted by GitBox <gi...@apache.org>.
haozhijie9527 commented on issue #3624:
URL: https://github.com/apache/rocketmq/issues/3624#issuecomment-992224840
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] yuz10 closed issue #3624: DefaultMQPushConsumerTest.testPullMessage_ExceptionOccursWhenComputePullFromWhere throws RejectedExecution
Posted by GitBox <gi...@apache.org>.
yuz10 closed issue #3624:
URL: https://github.com/apache/rocketmq/issues/3624
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] areyouok commented on issue #3624: DefaultMQPushConsumerTest.testPullMessage_ExceptionOccursWhenComputePullFromWhere throws RejectedExecution
Posted by GitBox <gi...@apache.org>.
areyouok commented on issue #3624:
URL: https://github.com/apache/rocketmq/issues/3624#issuecomment-992420954
> @haozhijie9527 @areyouok Please help to check again
The synchronized block in RequestFutureHolder is not saft enough. Concurrent problem still exists.
I sugguest move DefaultMQProducerImpl.startScheduledTask() and
```
if (RequestFutureHolder.getInstance().getProducerNum().decrementAndGet() == 0) {
RequestFutureHolder.getInstance().getScheduledExecutorService().shutdown();
}
```
to RequestFutureHolder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] panzhi33 commented on issue #3624: DefaultMQPushConsumerTest.testPullMessage_ExceptionOccursWhenComputePullFromWhere throws RejectedExecution
Posted by GitBox <gi...@apache.org>.
panzhi33 commented on issue #3624:
URL: https://github.com/apache/rocketmq/issues/3624#issuecomment-991144438
> @panzhi33 Could you take a look please?
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] yuz10 closed issue #3624: DefaultMQPushConsumerTest.testPullMessage_ExceptionOccursWhenComputePullFromWhere throws RejectedExecution
Posted by GitBox <gi...@apache.org>.
yuz10 closed issue #3624:
URL: https://github.com/apache/rocketmq/issues/3624
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] yuz10 commented on issue #3624: DefaultMQPushConsumerTest.testPullMessage_ExceptionOccursWhenComputePullFromWhere throws RejectedExecution
Posted by GitBox <gi...@apache.org>.
yuz10 commented on issue #3624:
URL: https://github.com/apache/rocketmq/issues/3624#issuecomment-991064414
@panzhi33
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] areyouok commented on issue #3624: DefaultMQPushConsumerTest.testPullMessage_ExceptionOccursWhenComputePullFromWhere throws RejectedExecution
Posted by GitBox <gi...@apache.org>.
areyouok commented on issue #3624:
URL: https://github.com/apache/rocketmq/issues/3624#issuecomment-992235808
1. create a producer
2. send one message
3. close the producer
4. create the second producer
5. RejectedExecutionException throws
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] panzhi33 commented on issue #3624: DefaultMQPushConsumerTest.testPullMessage_ExceptionOccursWhenComputePullFromWhere throws RejectedExecution
Posted by GitBox <gi...@apache.org>.
panzhi33 commented on issue #3624:
URL: https://github.com/apache/rocketmq/issues/3624#issuecomment-992417106
@haozhijie9527 @areyouok Please help to check again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] odbozhou closed issue #3624: DefaultMQPushConsumerTest.testPullMessage_ExceptionOccursWhenComputePullFromWhere throws RejectedExecution
Posted by GitBox <gi...@apache.org>.
odbozhou closed issue #3624:
URL: https://github.com/apache/rocketmq/issues/3624
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] panzhi33 commented on issue #3624: DefaultMQPushConsumerTest.testPullMessage_ExceptionOccursWhenComputePullFromWhere throws RejectedExecution
Posted by GitBox <gi...@apache.org>.
panzhi33 commented on issue #3624:
URL: https://github.com/apache/rocketmq/issues/3624#issuecomment-991435610
This is because org.apache.rocketmq.client.producer.RequestFutureHolder is a singleton class. If all the test cases are executed together, the thread pool in RequestFutureHolder will be closed after the execution of @After pushConsumer.shutdown() after the completion of the first test case, the following test cases will have this exception, and a single test is normal of. Now I modify @After to @AfterClass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] yuz10 edited a comment on issue #3624: DefaultMQPushConsumerTest.testPullMessage_ExceptionOccursWhenComputePullFromWhere throws RejectedExecution
Posted by GitBox <gi...@apache.org>.
yuz10 edited a comment on issue #3624:
URL: https://github.com/apache/rocketmq/issues/3624#issuecomment-991064414
@panzhi33 Could you take a look please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] odbozhou commented on issue #3624: DefaultMQPushConsumerTest.testPullMessage_ExceptionOccursWhenComputePullFromWhere throws RejectedExecution
Posted by GitBox <gi...@apache.org>.
odbozhou commented on issue #3624:
URL: https://github.com/apache/rocketmq/issues/3624#issuecomment-996458341
merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] panzhi33 commented on issue #3624: DefaultMQPushConsumerTest.testPullMessage_ExceptionOccursWhenComputePullFromWhere throws RejectedExecution
Posted by GitBox <gi...@apache.org>.
panzhi33 commented on issue #3624:
URL: https://github.com/apache/rocketmq/issues/3624#issuecomment-991435610
This is because org.apache.rocketmq.client.producer.RequestFutureHolder is a singleton class. If all the test cases are executed together, the thread pool in RequestFutureHolder will be closed after the execution of @After pushConsumer.shutdown() after the completion of the first test case, the following test cases will have this exception, and a single test is normal of. Now I modify @After to @AfterClass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] haozhijie9527 edited a comment on issue #3624: DefaultMQPushConsumerTest.testPullMessage_ExceptionOccursWhenComputePullFromWhere throws RejectedExecution
Posted by GitBox <gi...@apache.org>.
haozhijie9527 edited a comment on issue #3624:
URL: https://github.com/apache/rocketmq/issues/3624#issuecomment-992224840
@panzhi33 This problem still exists, and will cause the consumers we deploy in the production environment to fail to start
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] panzhi33 commented on issue #3624: DefaultMQPushConsumerTest.testPullMessage_ExceptionOccursWhenComputePullFromWhere throws RejectedExecution
Posted by GitBox <gi...@apache.org>.
panzhi33 commented on issue #3624:
URL: https://github.com/apache/rocketmq/issues/3624#issuecomment-992451468
> > @haozhijie9527 @areyouok Please help to check again
>
> The synchronized block in RequestFutureHolder is not safe enough. Concurrent problem still exists.
>
> I sugguest move DefaultMQProducerImpl.startScheduledTask() and
>
> ```
> if (RequestFutureHolder.getInstance().getProducerNum().decrementAndGet() == 0) {
> RequestFutureHolder.getInstance().getScheduledExecutorService().shutdown();
> }
> ```
>
> to RequestFutureHolder.
OK, it’s been revised, please take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org