[jira] [Created] (CASSANDRA-15311) Fix flakey test_13595 - consistency_test.TestConsistency

["Joseph Lynch (Jira)" <ji...@apache.org>]

Joseph Lynch created CASSANDRA-15311:
----------------------------------------

             Summary: Fix flakey  test_13595 - consistency_test.TestConsistency
                 Key: CASSANDRA-15311
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15311
             Project: Cassandra
          Issue Type: Bug
          Components: Test/dtest
            Reporter: Joseph Lynch


Example failure: [https://circleci.com/gh/jolynch/cassandra/559#tests/containers/29]
{noformat}
Your job ran 1007 tests with 1 failure
test_13595 - consistency_test.TestConsistencyconsistency_test.pyAssertionError: assert 9 == 4  +  where 4 = <bound method JolokiaAgent.read_attribute of <tools.jmxutils.JolokiaAgent object at 0x7f9f0775b160>>('org.apache.cassandra.metrics:type=Table,name=ShortReadProtectionRequests,keyspace=test,scope=test', 'Count')  +    where <bound method JolokiaAgent.read_attribute of <tools.jmxutils.JolokiaAgent object at 0x7f9f0775b160>> = <tools.jmxutils.JolokiaAgent object at 0x7f9f0775b160>.read_attribute
self = <consistency_test.TestConsistency object at 0x7f9f168c26d8>

    @since('3.0')
    def test_13595(self):
        """
            @jira_ticket CASSANDRA-13595
            """
        cluster = self.cluster
    
        # disable hinted handoff and set batch commit log so this doesn't interfere with the test
        cluster.set_configuration_options(values={'hinted_handoff_enabled': False})
        cluster.set_batch_commitlog(enabled=True)
    
        cluster.populate(2)
        node1, node2 = cluster.nodelist()
        remove_perf_disable_shared_mem(node1)  # necessary for jmx
        cluster.start(wait_other_notice=True)
    
        session = self.patient_cql_connection(node1)
    
        query = "CREATE KEYSPACE IF NOT EXISTS test WITH replication = {'class': 'NetworkTopologyStrategy', 'datacenter1': 2};"
        session.execute(query)
    
        query = 'CREATE TABLE IF NOT EXISTS test.test (id int PRIMARY KEY);'
        session.execute(query)
    
        # populate the table with 10 partitions,
        # then delete a bunch of them on different nodes
        # until we get the following pattern:
    
        #                token | k | 1 | 2 |
        # -7509452495886106294 | 5 | n | y |
        # -4069959284402364209 | 1 | y | n |
        # -3799847372828181882 | 8 | n | y |
        # -3485513579396041028 | 0 | y | n |
        # -3248873570005575792 | 2 | n | y |
        # -2729420104000364805 | 4 | y | n |
        #  1634052884888577606 | 7 | n | y |
        #  2705480034054113608 | 6 | y | n |
        #  3728482343045213994 | 9 | n | y |
        #  9010454139840013625 | 3 | y | y |
    
        stmt = session.prepare('INSERT INTO test.test (id) VALUES (?);')
        for id in range(0, 10):
            session.execute(stmt, [id], ConsistencyLevel.ALL)
    
        # delete every other partition on node1 while node2 is down
        node2.stop(wait_other_notice=True)
        session.execute('DELETE FROM test.test WHERE id IN (5, 8, 2, 7, 9);')
        node2.start(wait_other_notice=True, wait_for_binary_proto=True)
    
        session = self.patient_cql_connection(node2)
    
        # delete every other alternate partition on node2 while node1 is down
        node1.stop(wait_other_notice=True)
        session.execute('DELETE FROM test.test WHERE id IN (1, 0, 4, 6);')
        node1.start(wait_other_notice=True, wait_for_binary_proto=True)
    
        session = self.patient_exclusive_cql_connection(node1)
    
        # until #13595 the query would incorrectly return [1]
        assert_all(session,
                   'SELECT id FROM test.test LIMIT 1;',
                   [[3]],
                   cl=ConsistencyLevel.ALL)
    
        srp = make_mbean('metrics', type='Table', name='ShortReadProtectionRequests', keyspace='test', scope='test')
        with JolokiaAgent(node1) as jmx:
            # 4 srp requests for node1 and 5 for node2, total of 9
>           assert 9 == jmx.read_attribute(srp, 'Count')
E           AssertionError: assert 9 == 4
E            +  where 4 = <bound method JolokiaAgent.read_attribute of <tools.jmxutils.JolokiaAgent object at 0x7f9f0775b160>>('org.apache.cassandra.metrics:type=Table,name=ShortReadProtectionRequests,keyspace=test,scope=test', 'Count')
E            +    where <bound method JolokiaAgent.read_attribute of <tools.jmxutils.JolokiaAgent object at 0x7f9f0775b160>> = <tools.jmxutils.JolokiaAgent object at 0x7f9f0775b160>.read_attribute

consistency_test.py:1288: AssertionError {noformat}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org