[GitHub] [doris] github-actions[bot] commented on a diff in pull request #15652: [Pipeline](Exec) disable work steal of hash join build

[GitBox <gi...@apache.org>]

github-actions[bot] commented on code in PR #15652:
URL: https://github.com/apache/doris/pull/15652#discussion_r1062249978


##########
be/src/pipeline/pipeline.h:
##########
@@ -48,9 +51,11 @@ class Pipeline : public std::enable_shared_from_this<Pipeline> {
 
     // If all dependencies are finished, this pipeline task should be scheduled.
     // e.g. Hash join probe task will be scheduled once Hash join build task is finished.
-    bool finish_one_dependency() {
+    bool finish_one_dependency(int dependency_core_id) {
         DCHECK(_complete_dependency < _dependencies.size());
-        return _complete_dependency.fetch_add(1) == _dependencies.size() - 1;
+        bool finish = _complete_dependency.fetch_add(1) == _dependencies.size() - 1;
+        if (finish) _previous_schedule_id = dependency_core_id;

Review Comment:
   warning: statement should be inside braces [readability-braces-around-statements]
   
   ```suggestion
           if (finish) { _previous_schedule_id = dependency_core_id;
   }
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org