You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Steve Loughran (JIRA)" <ji...@apache.org> on 2014/06/02 10:32:02 UTC
[jira] [Resolved] (YARN-804) mark AbstractService init/start/stop
methods as final
[ https://issues.apache.org/jira/browse/YARN-804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Loughran resolved YARN-804.
---------------------------------
Resolution: Won't Fix
I don't think we can fix this while mocking is used to test some aspects of the implementation classes...WONTFIX unless there's a workaround
> mark AbstractService init/start/stop methods as final
> -----------------------------------------------------
>
> Key: YARN-804
> URL: https://issues.apache.org/jira/browse/YARN-804
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: api
> Affects Versions: 2.1.0-beta
> Reporter: Steve Loughran
> Assignee: Vinod Kumar Vavilapalli
> Attachments: YARN-804-001.patch
>
>
> Now that YARN-117 and MAPREDUCE-5298 are checked in, we can mark the public AbstractService init/start/stop methods as final.
> Why? It puts the lifecycle check and error handling around the subclass code, ensuring no lifecycle method gets called in the wrong state or gets called more than once.When a {{serviceInit(), serviceStart() & serviceStop()}} method throws an exception, it's caught and auto-triggers stop.
> Marking the methods as final forces service implementations to move to the stricter lifecycle. It has one side effect: some of the mocking tests play up -I'll need some assistance here
--
This message was sent by Atlassian JIRA
(v6.2#6252)