You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Ben Craig (JIRA)" <ji...@apache.org> on 2013/08/14 16:01:50 UTC
[jira] [Commented] (THRIFT-2119) Compiling the Thrift C++ Library
with Visual Studio 2005
[ https://issues.apache.org/jira/browse/THRIFT-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13739685#comment-13739685 ]
Ben Craig commented on THRIFT-2119:
-----------------------------------
The trunk has TAsyncChannel using apache::thrift::stdcxx::function, which turns into std::tr1::function. I don't think msvc 2005 supported TR1.
TAsyncChannel isn't strictly required. If you can omit it from your builds, then you should be fine. If you want to fix it for everybody, then you will want to tinker with cpp/src/thrift/cxxfunctional.h. If you add extra conditionals there, then you can probably point apache::thrift::stdcxx at boost::function for msvc 2005.
> Compiling the Thrift C++ Library with Visual Studio 2005
> --------------------------------------------------------
>
> Key: THRIFT-2119
> URL: https://issues.apache.org/jira/browse/THRIFT-2119
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Affects Versions: 0.9.1, 1.0
> Environment: Microsoft Visual Studio 2005.
> Reporter: Jonas
> Labels: patch
> Attachments: CMakeLists.txt, thrift_patch.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Hi,
> I created a patch (for the current trunk revision) to compile the Thrift C++ Library with Visual Studio 2005 (only libthrift, not libthriftnb for asynchronous calls).
> The patch essentially adds a few (forgotten?) #ifdef HAVE_STDINT_H and contains a workaround for a problem with SFINAE with the VS8 compiler.
> An additional problem appears with tr1::function when compiling TAsyncChannel.cpp. I excluded this source file from the build (it is required?).
> Could these changes be integrated in the trunk?
> Many thanks for your considerations,
> Best,
> Jonas
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira