You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metron.apache.org by merrimanr <gi...@git.apache.org> on 2017/05/10 19:52:48 UTC
[GitHub] incubator-metron pull request #581: METRON-844: Install Metron Management UI...
GitHub user merrimanr opened a pull request:
https://github.com/apache/incubator-metron/pull/581
METRON-844: Install Metron Management UI with Ambari MPack
## Contributor Comments
This PR adds the Management UI into the Ambari MPack. Testing should be very simple: spin up full dev and verify the Management UI is running, accessible from Quick Links, and can be stopped/started/restarted through Ambari.
The README should also be reviewed for clarity since it includes manual install instructions and instructions on starting the UI locally for development.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.
Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
### For code changes:
- [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been executed in the root incubating-metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [ ] Have you written or updated unit tests and or integration tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/merrimanr/incubator-metron METRON-844
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-metron/pull/581.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #581
----
commit eaa41f5849208846347ed286ea7239e61bd31b07
Author: merrimanr <me...@gmail.com>
Date: 2017-05-08T12:49:06Z
Resolved merge conflicts with METRON-799 and METRON-795
commit 8fe2663cdebe4b03ca71db0ec66a3a1fb2926ab9
Author: merrimanr <me...@gmail.com>
Date: 2017-05-09T14:43:32Z
Updated README
commit 68254c67f2f54493666bce60dfc40062b14f9de1
Author: merrimanr <me...@gmail.com>
Date: 2017-05-09T14:44:05Z
Merge remote-tracking branch 'mirror/master' into METRON-844
commit 248cf1a36349074796dd060d746b63c1c8da4fe6
Author: merrimanr <me...@gmail.com>
Date: 2017-05-09T20:42:40Z
Merge remote-tracking branch 'mirror/master' into METRON-844
# Conflicts:
# metron-deployment/packaging/docker/rpm-docker/SPECS/metron.spec
commit 548e223d00cd7e696d6af777f0ab93aaa63a9504
Author: merrimanr <me...@gmail.com>
Date: 2017-05-09T23:36:38Z
Resolved merge conflict
commit b37a5a3cf9b33f020f88a2420e96454941695a44
Author: merrimanr <me...@gmail.com>
Date: 2017-05-10T13:05:13Z
Merge remote-tracking branch 'mirror/master' into METRON-844
# Conflicts:
# metron-deployment/packaging/docker/rpm-docker/SPECS/metron.spec
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request #581: METRON-844: Install Metron Management UI...
Posted by simonellistonball <gi...@git.apache.org>.
Github user simonellistonball commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/581#discussion_r115962297
--- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/management_ui_master.py ---
@@ -0,0 +1,91 @@
+"""
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+
+"""
+
+from resource_management.core.exceptions import ComponentIsNotRunning
+from resource_management.core.exceptions import ExecutionFailed
+from resource_management.core.resources.system import Directory
+from resource_management.core.resources.system import File
+from resource_management.core.source import Template
+from resource_management.libraries.functions.format import format
+from resource_management.libraries.script import Script
+from resource_management.core.resources.system import Execute
+
+from resource_management.core.logger import Logger
+
+from management_ui_commands import ManagementUICommands
+
+
+class ManagementUIMaster(Script):
+
+ def install(self, env):
+ Execute('curl --silent --location https://rpm.nodesource.com/setup_6.x | bash - && yum -y install nodejs')
--- End diff --
This would be a problem for offline installs. We cannot rely on the internet being around to install node.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---