You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Ramesh Mani <rm...@hortonworks.com> on 2018/05/17 20:06:39 UTC
Review Request 67192: RANGER-2105:Ranger HiveAuthorization for INSERT
OVERWRITE DIRECTORY
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67192/
-----------------------------------------------------------
Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Thejas Nair, and Velmurugan Periasamy.
Bugs: RANGER-2105
https://issues.apache.org/jira/browse/RANGER-2105
Repository: ranger
Description
-------
RANGER-2105:Ranger HiveAuthorization for INSERT OVERWRITE DIRECTORY
Diffs
-----
hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java 780afac
Diff: https://reviews.apache.org/r/67192/diff/1/
Testing
-------
Testing done in Local VM
Thanks,
Ramesh Mani
Re: Review Request 67192: RANGER-2105:Ranger HiveAuthorization for
INSERT OVERWRITE DIRECTORY
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67192/#review203397
-----------------------------------------------------------
hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java
Line 271 (original), 271 (patched)
<https://reviews.apache.org/r/67192/#comment285587>
getURIAccessType() is called only when hiveObjType is URI - both in #271 and #317. Please review if it is necessary to send in hiveObjType as parameter.
- Madhan Neethiraj
On May 17, 2018, 8:06 p.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67192/
> -----------------------------------------------------------
>
> (Updated May 17, 2018, 8:06 p.m.)
>
>
> Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Thejas Nair, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2105
> https://issues.apache.org/jira/browse/RANGER-2105
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-2105:Ranger HiveAuthorization for INSERT OVERWRITE DIRECTORY
>
>
> Diffs
> -----
>
> hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java 780afac
>
>
> Diff: https://reviews.apache.org/r/67192/diff/1/
>
>
> Testing
> -------
>
> Testing done in Local VM
>
>
> Thanks,
>
> Ramesh Mani
>
>
Re: Review Request 67192: RANGER-2105:Ranger HiveAuthorization for
INSERT OVERWRITE DIRECTORY
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67192/#review203495
-----------------------------------------------------------
Ship it!
Ship It!
- Velmurugan Periasamy
On May 18, 2018, 6:24 a.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67192/
> -----------------------------------------------------------
>
> (Updated May 18, 2018, 6:24 a.m.)
>
>
> Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Thejas Nair, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2105
> https://issues.apache.org/jira/browse/RANGER-2105
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-2105:Ranger HiveAuthorization for INSERT OVERWRITE DIRECTORY
>
>
> Diffs
> -----
>
> hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java 780afac
>
>
> Diff: https://reviews.apache.org/r/67192/diff/2/
>
>
> Testing
> -------
>
> Testing done in Local VM
>
>
> Thanks,
>
> Ramesh Mani
>
>
Re: Review Request 67192: RANGER-2105:Ranger HiveAuthorization for
INSERT OVERWRITE DIRECTORY
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67192/
-----------------------------------------------------------
(Updated May 18, 2018, 6:24 a.m.)
Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Thejas Nair, and Velmurugan Periasamy.
Changes
-------
Fixed review comments
Bugs: RANGER-2105
https://issues.apache.org/jira/browse/RANGER-2105
Repository: ranger
Description
-------
RANGER-2105:Ranger HiveAuthorization for INSERT OVERWRITE DIRECTORY
Diffs (updated)
-----
hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java 780afac
Diff: https://reviews.apache.org/r/67192/diff/2/
Changes: https://reviews.apache.org/r/67192/diff/1-2/
Testing
-------
Testing done in Local VM
Thanks,
Ramesh Mani