[GitHub] [spark] panbingkun commented on a diff in pull request #39270: [SPARK-41754][UI] Add simple developer guides for UI Protobuf serializer

[GitBox <gi...@apache.org>]

panbingkun commented on code in PR #39270:
URL: https://github.com/apache/spark/pull/39270#discussion_r1058802006


##########
core/src/main/protobuf/org/apache/spark/status/protobuf/store_types.proto:
##########
@@ -18,8 +18,15 @@
 syntax = "proto3";
 package org.apache.spark.status.protobuf;
 
+/**
+ * Developer guides:
+ *   - Coding style: https://developers.google.com/protocol-buffers/docs/style
+ *   - Use int64 for job/stage IDs, in case of future extension in Spark core.
+ *   - Use `weakIntern` on string values in create new objects during deserialization.

Review Comment:
   https://issues.apache.org/jira/browse/SPARK-41759 @LuciferYang @gengliangwang 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org