[jira] [Commented] (HBASE-11877) Make TableSplit more readable

["Jean-Marc Spaggiari (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-11877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118184#comment-14118184 ] 

Jean-Marc Spaggiari commented on HBASE-11877:
---------------------------------------------

Don't see any issue with that. Have you ran it locally? Do you have a copy of the output? Has it passed the tests?  Not anyrisk for those new fields (m_tableName, m_regionLocation) to be null? I don't think so, but just asking.

> Make TableSplit more readable
> -----------------------------
>
>                 Key: HBASE-11877
>                 URL: https://issues.apache.org/jira/browse/HBASE-11877
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Liu Shaohui
>            Assignee: Liu Shaohui
>            Priority: Minor
>         Attachments: HBASE-11877-trunk-v1.diff
>
>
> When debugging MR jobs reading from hbase table, it's import to figure out which region a map task is reading from.
> But the table split object is hard to read.
> eg:
> {code}
> 2014-09-01 20:58:39,783 INFO [main] org.apache.hadoop.mapred.MapTask: Processing split: lg-hadoop-prc-st40.bj:,0
> {code}
> See: TableSplit.java 
> {code}
>   @Override
>   public String toString() {
>     return m_regionLocation + ":" +
>       Bytes.toStringBinary(m_startRow) + "," + Bytes.toStringBinary(m_endRow);
>   }
> {code}
> We should make it more readable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)