You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@pdfbox.apache.org by GitBox <gi...@apache.org> on 2021/09/24 23:36:52 UTC

[GitHub] [pdfbox] wx930910 opened a new pull request #130: PDFBOX-5284: Refactor Refactor PDFTabulaTextStripper to improve test …

wx930910 opened a new pull request #130:
URL: https://github.com/apache/pdfbox/pull/130


   ### Jira
   
   - [PDFBOX-5284](https://issues.apache.org/jira/browse/PDFBOX-5284)
   
   ### Description
   
   #### Replace test class [PDFTabulaTextStripper](https://github.com/apache/pdfbox/blob/588cb208653262ada43732a4e61c6fa3158f45f4/pdfbox/src/test/java/org/apache/pdfbox/text/TestTextStripper.java#L619) by spying object and improve test design
   <hr>
   
   ##### Motivation
   
   * Decouple test class `PDFTabulaTextStripper` from production class `PDFTextStripper`.
    * Remove the redundant test child class `PDFTabulaTextStripper`
    * Remove the redundant constructor.
   
   <hr>
   
   ##### Key changed/added classes in this PR
    * Created spying object to replace test subclass `PDFTabulaTextStripper`, decoupled test from production code.
    * Created method that return the mocking object for code reuse.
   
   <hr>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org