You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by su...@apache.org on 2019/01/09 17:11:17 UTC
[incubator-pinot] 02/04: Rename DocBased to NoDictionaryBased
creators
This is an automated email from the ASF dual-hosted git repository.
sunithabeeram pushed a commit to branch pinot-text-search
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
commit d7bf303b2d4843c20d02026770ed636daa161ed8
Author: Sunitha Beeram <sb...@linkedin.com>
AuthorDate: Mon Jan 7 04:11:26 2019 -0800
Rename DocBased to NoDictionaryBased creators
---
...tor.java => NoDictionaryBasedInvertedIndexCreator.java} | 6 +++---
.../segment/creator/impl/SegmentColumnarIndexCreator.java | 14 +++++++-------
.../creator/impl/textsearch/LuceneIndexCreator.java | 4 ++--
.../impl/textsearch/TextSearchIndexCreatorFactory.java | 4 ++--
4 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/pinot-core/src/main/java/com/linkedin/pinot/core/segment/creator/DocBasedInvertedIndexCreator.java b/pinot-core/src/main/java/com/linkedin/pinot/core/segment/creator/NoDictionaryBasedInvertedIndexCreator.java
similarity index 81%
rename from pinot-core/src/main/java/com/linkedin/pinot/core/segment/creator/DocBasedInvertedIndexCreator.java
rename to pinot-core/src/main/java/com/linkedin/pinot/core/segment/creator/NoDictionaryBasedInvertedIndexCreator.java
index 884d446..a91c7d8 100644
--- a/pinot-core/src/main/java/com/linkedin/pinot/core/segment/creator/DocBasedInvertedIndexCreator.java
+++ b/pinot-core/src/main/java/com/linkedin/pinot/core/segment/creator/NoDictionaryBasedInvertedIndexCreator.java
@@ -16,12 +16,12 @@
package com.linkedin.pinot.core.segment.creator;
/**
- * A document object based InvertedIndexCreator.
+ * A No-Dictionary based InvertedIndexCreator.
*/
-public interface DocBasedInvertedIndexCreator extends InvertedIndexCreator {
+public interface NoDictionaryBasedInvertedIndexCreator extends InvertedIndexCreator {
/**
- * Add a document/text field to the index
+ * Add a document field to the index
*/
void add(Object doc);
}
diff --git a/pinot-core/src/main/java/com/linkedin/pinot/core/segment/creator/impl/SegmentColumnarIndexCreator.java b/pinot-core/src/main/java/com/linkedin/pinot/core/segment/creator/impl/SegmentColumnarIndexCreator.java
index 44cf3a1..bd43647 100644
--- a/pinot-core/src/main/java/com/linkedin/pinot/core/segment/creator/impl/SegmentColumnarIndexCreator.java
+++ b/pinot-core/src/main/java/com/linkedin/pinot/core/segment/creator/impl/SegmentColumnarIndexCreator.java
@@ -29,7 +29,7 @@ import com.linkedin.pinot.core.io.compression.ChunkCompressorFactory;
import com.linkedin.pinot.core.io.util.PinotDataBitSet;
import com.linkedin.pinot.core.segment.creator.ColumnIndexCreationInfo;
import com.linkedin.pinot.core.segment.creator.DictionaryBasedInvertedIndexCreator;
-import com.linkedin.pinot.core.segment.creator.DocBasedInvertedIndexCreator;
+import com.linkedin.pinot.core.segment.creator.NoDictionaryBasedInvertedIndexCreator;
import com.linkedin.pinot.core.segment.creator.ForwardIndexCreator;
import com.linkedin.pinot.core.segment.creator.InvertedIndexCreator;
import com.linkedin.pinot.core.segment.creator.MultiValueForwardIndexCreator;
@@ -80,7 +80,7 @@ public class SegmentColumnarIndexCreator implements SegmentCreator {
private Map<String, SegmentDictionaryCreator> _dictionaryCreatorMap = new HashMap<>();
private Map<String, ForwardIndexCreator> _forwardIndexCreatorMap = new HashMap<>();
private Map<String, DictionaryBasedInvertedIndexCreator> _invertedIndexCreatorMap = new HashMap<>();
- private Map<String, DocBasedInvertedIndexCreator> _docBasedInvertedIndexCreatorMap = new HashMap<>();
+ private Map<String, NoDictionaryBasedInvertedIndexCreator> _noDictionaryIndexCreatorMap = new HashMap<>();
private String segmentName;
private Schema schema;
private File _indexDir;
@@ -195,7 +195,7 @@ public class SegmentColumnarIndexCreator implements SegmentCreator {
config = TextSearchIndexConfig.getDefaultConfig(columnName, _indexDir);
}
createFwdIndex = config.shouldStore();
- _docBasedInvertedIndexCreatorMap.put(columnName, TextSearchIndexCreatorFactory.createSearchIndexer(config));
+ _noDictionaryIndexCreatorMap.put(columnName, TextSearchIndexCreatorFactory.createSearchIndexer(config));
}
if (createFwdIndex) {
@@ -277,9 +277,9 @@ public class SegmentColumnarIndexCreator implements SegmentCreator {
throw new RuntimeException("Null value for column:" + columnName);
}
- if (_docBasedInvertedIndexCreatorMap.containsKey(columnName)) {
+ if (_noDictionaryIndexCreatorMap.containsKey(columnName)) {
// inverted index
- _docBasedInvertedIndexCreatorMap.get(columnName).add(columnValueToIndex);
+ _noDictionaryIndexCreatorMap.get(columnName).add(columnValueToIndex);
// forward index
((SingleValueRawIndexCreator) _forwardIndexCreatorMap.get(columnName)).index(docIdCounter,
columnValueToIndex);
@@ -318,7 +318,7 @@ public class SegmentColumnarIndexCreator implements SegmentCreator {
for (InvertedIndexCreator invertedIndexCreator : _invertedIndexCreatorMap.values()) {
invertedIndexCreator.seal();
}
- for (DocBasedInvertedIndexCreator docIndexCreator : _docBasedInvertedIndexCreatorMap.values()) {
+ for (NoDictionaryBasedInvertedIndexCreator docIndexCreator : _noDictionaryIndexCreatorMap.values()) {
docIndexCreator.seal();
}
writeMetadata();
@@ -569,7 +569,7 @@ public class SegmentColumnarIndexCreator implements SegmentCreator {
for (InvertedIndexCreator invertedIndexCreator : _invertedIndexCreatorMap.values()) {
invertedIndexCreator.close();
}
- for (DocBasedInvertedIndexCreator docIndexCreator : _docBasedInvertedIndexCreatorMap.values()) {
+ for (NoDictionaryBasedInvertedIndexCreator docIndexCreator : _noDictionaryIndexCreatorMap.values()) {
docIndexCreator.close();
}
}
diff --git a/pinot-core/src/main/java/com/linkedin/pinot/core/segment/creator/impl/textsearch/LuceneIndexCreator.java b/pinot-core/src/main/java/com/linkedin/pinot/core/segment/creator/impl/textsearch/LuceneIndexCreator.java
index 2381113..f630e85 100644
--- a/pinot-core/src/main/java/com/linkedin/pinot/core/segment/creator/impl/textsearch/LuceneIndexCreator.java
+++ b/pinot-core/src/main/java/com/linkedin/pinot/core/segment/creator/impl/textsearch/LuceneIndexCreator.java
@@ -15,7 +15,7 @@
*/
package com.linkedin.pinot.core.segment.creator.impl.textsearch;
-import com.linkedin.pinot.core.segment.creator.DocBasedInvertedIndexCreator;
+import com.linkedin.pinot.core.segment.creator.NoDictionaryBasedInvertedIndexCreator;
import java.io.File;
import java.io.IOException;
import org.apache.lucene.analysis.standard.StandardAnalyzer;
@@ -30,7 +30,7 @@ import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-class LuceneIndexCreator implements DocBasedInvertedIndexCreator {
+class LuceneIndexCreator implements NoDictionaryBasedInvertedIndexCreator {
private static final Logger LOGGER = LoggerFactory.getLogger(LuceneIndexCreator.class);
diff --git a/pinot-core/src/main/java/com/linkedin/pinot/core/segment/creator/impl/textsearch/TextSearchIndexCreatorFactory.java b/pinot-core/src/main/java/com/linkedin/pinot/core/segment/creator/impl/textsearch/TextSearchIndexCreatorFactory.java
index bd05b62..d31a183 100644
--- a/pinot-core/src/main/java/com/linkedin/pinot/core/segment/creator/impl/textsearch/TextSearchIndexCreatorFactory.java
+++ b/pinot-core/src/main/java/com/linkedin/pinot/core/segment/creator/impl/textsearch/TextSearchIndexCreatorFactory.java
@@ -15,12 +15,12 @@
*/
package com.linkedin.pinot.core.segment.creator.impl.textsearch;
-import com.linkedin.pinot.core.segment.creator.DocBasedInvertedIndexCreator;
+import com.linkedin.pinot.core.segment.creator.NoDictionaryBasedInvertedIndexCreator;
public class TextSearchIndexCreatorFactory {
- public static DocBasedInvertedIndexCreator createSearchIndexer(TextSearchIndexConfig config) {
+ public static NoDictionaryBasedInvertedIndexCreator createSearchIndexer(TextSearchIndexConfig config) {
switch (config.getType()) {
case LUCENE:
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org