You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "Shanedell (via GitHub)" <gi...@apache.org> on 2023/01/24 17:08:24 UTC

[GitHub] [daffodil-vscode] Shanedell commented on a diff in pull request #253: Daffodil vscode tdml

Shanedell commented on code in PR #253:
URL: https://github.com/apache/daffodil-vscode/pull/253#discussion_r1085632072


##########
src/tests/data/png.dfdl.xsd:
##########
@@ -0,0 +1,764 @@
+<?xml version="1.0" encoding="UTF-8"?>

Review Comment:
   As I have learned from @stevedlawrence , do not add this file into the repo. Its license is not compatible with ALv2 I believe. You will instead want to make a custom schema for testing, something similar to what we have in `main`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org