[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #3979: Track Indexed timestamp across consuming segments

[GitBox <gi...@apache.org>]

mcvsubbu commented on a change in pull request #3979: Track Indexed timestamp across consuming segments
URL: https://github.com/apache/incubator-pinot/pull/3979#discussion_r266511438
 
 

 ##########
 File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/BrokerReduceService.java
 ##########
 @@ -168,6 +180,14 @@ public BrokerResponseNative reduceOnDataTable(@Nonnull BrokerRequest brokerReque
     brokerResponseNative.setNumSegmentsMatched(numSegmentsMatched);
     brokerResponseNative.setTotalDocs(numTotalRawDocs);
     brokerResponseNative.setNumGroupsLimitReached(numGroupsLimitReached);
+    if (numConsumingQueried > 0) {
+      if (minConsumingIndexTs == Long.MAX_VALUE) {
+        LOGGER.error("Invalid lastIndexedTimestamp across {} consuming segments", numConsumingQueried);
 
 Review comment:
   Log the query ID here so that we can use it to correlate query logs. Also, please ensure that if this condition happens we override the throttle in the broker logs.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org