You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "Subzer0570 (via GitHub)" <gi...@apache.org> on 2023/02/16 18:19:56 UTC
[GitHub] [fineract] Subzer0570 opened a new pull request, #2982: Liquibase error for mysql for file "0043_add_external_event_table.xml"
Subzer0570 opened a new pull request, #2982:
URL: https://github.com/apache/fineract/pull/2982
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [X] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [X] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on pull request #2982: Liquibase error for mysql for file "0043_add_external_event_table.xml"
Posted by "vidakovic (via GitHub)" <gi...@apache.org>.
vidakovic commented on PR #2982:
URL: https://github.com/apache/fineract/pull/2982#issuecomment-1467710343
@Subzer0570 I am going to close this PR, because this approach won't work, you can't change an existing Liquibase script, you have to create a new one to fix this bug. I've created a Jira ticket for you https://issues.apache.org/jira/browse/FINERACT-1907.
Having said that: please follow the naming guidelines for PR (in this case the title would be "FINERACT-1907: Wrong column type for MySQL in Liquibase 0043_add_external_event_table.xml") and please squash your commits into one.
Thanks again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic closed pull request #2982: Liquibase error for mysql for file "0043_add_external_event_table.xml"
Posted by "vidakovic (via GitHub)" <gi...@apache.org>.
vidakovic closed pull request #2982: Liquibase error for mysql for file "0043_add_external_event_table.xml"
URL: https://github.com/apache/fineract/pull/2982
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] adamsaghy commented on pull request #2982: Liquibase error for mysql for file "0043_add_external_event_table.xml"
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #2982:
URL: https://github.com/apache/fineract/pull/2982#issuecomment-1434760411
Kindly asking you to create a bug ticket for this in Fineract jira and try to share some details why it was failing for you. Under that ticket we can investigate this issue and discuss the details of the fix. your PR is a good starting point however these fixes should be assigned to a Fineract ticket and also if we are touching this fields we might wanna even go further and enhance them to support Timestamp with timezone for postgres and datetime for mysql and offsetdatetime at JPA side so we can assure a valid UTC got stored in it as it was doing with many other entities (like: Loan)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org