You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by da...@apache.org on 2016/10/31 05:31:20 UTC

maven-wagon git commit: [WAGON-466] Better error for locked ssh account

Repository: maven-wagon
Updated Branches:
  refs/heads/master df7be7dc5 -> 412c0fbd7


[WAGON-466] Better error for locked ssh account

Instead of seeing ArrayOutOfBoundException, user now see "Too many
authentication failure" must less confusion

Project: http://git-wip-us.apache.org/repos/asf/maven-wagon/repo
Commit: http://git-wip-us.apache.org/repos/asf/maven-wagon/commit/412c0fbd
Tree: http://git-wip-us.apache.org/repos/asf/maven-wagon/tree/412c0fbd
Diff: http://git-wip-us.apache.org/repos/asf/maven-wagon/diff/412c0fbd

Branch: refs/heads/master
Commit: 412c0fbd7fb0107804080bb4b58bb0f249c0768a
Parents: df7be7d
Author: Dan Tran <da...@gmail.com>
Authored: Sun Oct 30 22:30:53 2016 -0700
Committer: Dan Tran <da...@gmail.com>
Committed: Sun Oct 30 22:30:53 2016 -0700

----------------------------------------------------------------------
 .../ssh/jsch/interactive/UserInfoUIKeyboardInteractiveProxy.java   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/maven-wagon/blob/412c0fbd/wagon-providers/wagon-ssh/src/main/java/org/apache/maven/wagon/providers/ssh/jsch/interactive/UserInfoUIKeyboardInteractiveProxy.java
----------------------------------------------------------------------
diff --git a/wagon-providers/wagon-ssh/src/main/java/org/apache/maven/wagon/providers/ssh/jsch/interactive/UserInfoUIKeyboardInteractiveProxy.java b/wagon-providers/wagon-ssh/src/main/java/org/apache/maven/wagon/providers/ssh/jsch/interactive/UserInfoUIKeyboardInteractiveProxy.java
index d728b58..c26df38 100644
--- a/wagon-providers/wagon-ssh/src/main/java/org/apache/maven/wagon/providers/ssh/jsch/interactive/UserInfoUIKeyboardInteractiveProxy.java
+++ b/wagon-providers/wagon-ssh/src/main/java/org/apache/maven/wagon/providers/ssh/jsch/interactive/UserInfoUIKeyboardInteractiveProxy.java
@@ -48,7 +48,7 @@ public class UserInfoUIKeyboardInteractiveProxy
     public String[] promptKeyboardInteractive( String destination, String name, String instruction, String[] prompt,
                                                boolean[] echo )
     {
-        if ( userInfo.getPassword() != null )
+        if ( userInfo.getPassword() != null && prompt != null && prompt.length != 0 )
         {
             prompt[0] = "Keyboard interactive required, supplied password is ignored\n" + prompt[0];
         }