You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2020/09/23 11:10:19 UTC
[GitHub] [cassandra-dtest] adelapena opened a new pull request #95: CASSANDRA 15977 4.0 quality testing: Read Repair
adelapena opened a new pull request #95:
URL: https://github.com/apache/cassandra-dtest/pull/95
Disable read repair tests included in 4.x in-JVM dtests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] adelapena commented on a change in pull request #95: CASSANDRA 15977 4.0 quality testing: Read Repair
Posted by GitBox <gi...@apache.org>.
adelapena commented on a change in pull request #95:
URL: https://github.com/apache/cassandra-dtest/pull/95#discussion_r493889993
##########
File path: read_repair_test.py
##########
@@ -732,106 +730,6 @@ def stop_reads(*nodes, kind='all'):
with _byteman_cycle(nodes, {'data': [data], 'digest': [digest], 'all': [data, digest]}[kind]):
yield
-kcvv = lambda k, c, v1, v2: [k, c, v1, v2]
-
-
-class TestReadRepairGuarantees(Tester):
Review comment:
@maedhroz Yes, we initially did a literal migration of this class that we discarded because we considered that the tested cases were already covered by the existing tests. However, just removing this class feels a bit scary to me, perhaps we could keep it around by now with a deprecation note, WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] adelapena closed pull request #95: CASSANDRA 15977 4.0 quality testing: Read Repair
Posted by GitBox <gi...@apache.org>.
adelapena closed pull request #95:
URL: https://github.com/apache/cassandra-dtest/pull/95
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] maedhroz commented on a change in pull request #95: CASSANDRA 15977 4.0 quality testing: Read Repair
Posted by GitBox <gi...@apache.org>.
maedhroz commented on a change in pull request #95:
URL: https://github.com/apache/cassandra-dtest/pull/95#discussion_r493878756
##########
File path: read_repair_test.py
##########
@@ -732,106 +730,6 @@ def stop_reads(*nodes, kind='all'):
with _byteman_cycle(nodes, {'data': [data], 'digest': [digest], 'all': [data, digest]}[kind]):
yield
-kcvv = lambda k, c, v1, v2: [k, c, v1, v2]
-
-
-class TestReadRepairGuarantees(Tester):
Review comment:
@adelapena Just to confirm, this is removed entirely because it was added in 4.0 anyway?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] adelapena commented on a change in pull request #95: CASSANDRA 15977 4.0 quality testing: Read Repair
Posted by GitBox <gi...@apache.org>.
adelapena commented on a change in pull request #95:
URL: https://github.com/apache/cassandra-dtest/pull/95#discussion_r502536645
##########
File path: read_repair_test.py
##########
@@ -732,106 +730,6 @@ def stop_reads(*nodes, kind='all'):
with _byteman_cycle(nodes, {'data': [data], 'digest': [digest], 'all': [data, digest]}[kind]):
yield
-kcvv = lambda k, c, v1, v2: [k, c, v1, v2]
-
-
-class TestReadRepairGuarantees(Tester):
Review comment:
@maedhroz as mentioned [on Slack](https://the-asf.slack.com/archives/CK23JSY2K/p1602201135179400), I have created [here](https://github.com/adelapena/cassandra-dtest/commit/50f3c020eb6a577c08deed5b35c466976a428301) a specific Pytest marker to skip tests ported to in-JVM only if we are not using vnodes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] adelapena commented on a change in pull request #95: CASSANDRA 15977 4.0 quality testing: Read Repair
Posted by GitBox <gi...@apache.org>.
adelapena commented on a change in pull request #95:
URL: https://github.com/apache/cassandra-dtest/pull/95#discussion_r502536645
##########
File path: read_repair_test.py
##########
@@ -732,106 +730,6 @@ def stop_reads(*nodes, kind='all'):
with _byteman_cycle(nodes, {'data': [data], 'digest': [digest], 'all': [data, digest]}[kind]):
yield
-kcvv = lambda k, c, v1, v2: [k, c, v1, v2]
-
-
-class TestReadRepairGuarantees(Tester):
Review comment:
@maedhroz as mentioned [on Slack](https://the-asf.slack.com/archives/CK23JSY2K/p1602201135179400), I have created [here](https://github.com/apache/cassandra-dtest/pull/95/commits/1d5c6460a9b5b744c29eacf1f7fddd2dde5ec4d0) a specific Pytest marker to skip tests ported to in-JVM only if we are not using vnodes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] adelapena commented on a change in pull request #95: CASSANDRA 15977 4.0 quality testing: Read Repair
Posted by GitBox <gi...@apache.org>.
adelapena commented on a change in pull request #95:
URL: https://github.com/apache/cassandra-dtest/pull/95#discussion_r502536645
##########
File path: read_repair_test.py
##########
@@ -732,106 +730,6 @@ def stop_reads(*nodes, kind='all'):
with _byteman_cycle(nodes, {'data': [data], 'digest': [digest], 'all': [data, digest]}[kind]):
yield
-kcvv = lambda k, c, v1, v2: [k, c, v1, v2]
-
-
-class TestReadRepairGuarantees(Tester):
Review comment:
@maedhroz as mentioned [on Slack|https://the-asf.slack.com/archives/CK23JSY2K/p1602201135179400], I have created [here](https://github.com/apache/cassandra-dtest/pull/95/commits/1d5c6460a9b5b744c29eacf1f7fddd2dde5ec4d0) a specific Pytest marker to skip tests ported to in-JVM only if we are not using vnodes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-dtest] maedhroz commented on a change in pull request #95: CASSANDRA 15977 4.0 quality testing: Read Repair
Posted by GitBox <gi...@apache.org>.
maedhroz commented on a change in pull request #95:
URL: https://github.com/apache/cassandra-dtest/pull/95#discussion_r493894661
##########
File path: read_repair_test.py
##########
@@ -732,106 +730,6 @@ def stop_reads(*nodes, kind='all'):
with _byteman_cycle(nodes, {'data': [data], 'digest': [digest], 'all': [data, digest]}[kind]):
yield
-kcvv = lambda k, c, v1, v2: [k, c, v1, v2]
-
-
-class TestReadRepairGuarantees(Tester):
Review comment:
I don't see any reason to worry about removing it. If we did all this work over again (transient replication, etc.), we'd probably end up with exactly what we've done in this issue. On the other hand, it doesn't hurt to keep it around for 4.0. I'll defer to your and our second reviewer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org